Last modified: 2014-09-25 11:33:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66742, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64742 - Wrong century rounding is applied when entering Time values
Wrong century rounding is applied when entering Time values
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High critical (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=8 s=2014-09-23
:
Depends on: 70935
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-02 10:46 UTC by Henning
Modified: 2014-09-25 11:33 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Henning 2014-05-02 10:46:50 UTC
When the intention is to enter a century, one has to enter a year and then switch the precision via the advanced options. However, entering a year belonging to the first half of a century, will actually detect the previous (wrong) century, for example:
Specifying a year between 1201 to 1249 will be detected as 12th century (though it should be 13th century) while all years from 1250 to 1349 are detected as 13th century. Inappropriate rounding seems to be applied.
Comment 1 pascal.leimer 2014-09-16 18:51:14 UTC
The bug might be located in lib/includes/formatters/MwTimeIsoFormatter.php
One could probably resolve it by replacing lines 211/212 by something like:
$fullYear = ceil( $fullYear/100 );
Comment 2 Gerrit Notification Bot 2014-09-23 14:46:29 UTC
Change 162242 had a related patch set uploaded by Daniel Kinzler:
Fix counting of centuries and millennia.

https://gerrit.wikimedia.org/r/162242
Comment 3 Gerrit Notification Bot 2014-09-25 10:44:53 UTC
Change 162242 merged by jenkins-bot:
Fix counting of centuries and millennia.

https://gerrit.wikimedia.org/r/162242

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links