Last modified: 2014-05-14 13:41:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66743, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64743 - Re-use the same instance of SiteSQLStore everywhere.
Re-use the same instance of SiteSQLStore everywhere.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-02 11:08 UTC by Daniel Kinzler
Modified: 2014-05-14 13:41 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-05-02 11:08:33 UTC 
Currently, SiteSQLStore::newInstance() is used in a lot of places that need to look up Sites. This means we have to fetch the site list (~800 entries that need to be uncompressed and deserialized) from memcached (via TCP) over and over. 

We should inject the SiteStore where possible, and rely on a application scope singleton in WikibaseRepo resp WikibaseClient in static entry points.
Comment 1 Daniel Kinzler 2014-05-13 11:33:12 UTC 
marius, can you look into this?
Comment 2 Gerrit Notification Bot 2014-05-13 22:09:40 UTC 
Change 133179 had a related patch set uploaded by Hoo man:
Avoid SiteSQLStore::newInstance and the deprecated Sites class

https://gerrit.wikimedia.org/r/133179
Comment 3 Gerrit Notification Bot 2014-05-14 13:33:01 UTC 
Change 133179 merged by jenkins-bot:
Avoid SiteSQLStore::newInstance and the deprecated Sites class

https://gerrit.wikimedia.org/r/133179
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links