Last modified: 2014-05-06 02:45:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66751, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64751 - VisualEditor: Transition between read mode and edit mode should have minimal visual shifts
VisualEditor: Transition between read mode and edit mode should have minimal ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-05-08
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-02 16:44 UTC by Krinkle
Modified: 2014-05-06 02:45 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-05-02 16:44:45 UTC
Issues right now:

* Different set of elements (e.g. #contentSub is shown in read mode, but not in edit mode. The same goes for TOC, though we do account for that one).

* Different offset (the toolbar is injected which causes an abrupt visual shift).

* Different scroll offset (same as before, but applies when you open the editor when scrolled down the page, after the transition, you're looking at a potentially very different part of the document, we should preserve it or jump to the top, not leave you somewhere randomly).
Comment 1 Gerrit Notification Bot 2014-05-02 16:45:07 UTC
Change 131071 had a related patch set uploaded by Krinkle:
ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup

https://gerrit.wikimedia.org/r/131071
Comment 2 Gerrit Notification Bot 2014-05-02 16:46:19 UTC
Change 131074 had a related patch set uploaded by Krinkle:
ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted

https://gerrit.wikimedia.org/r/131074
Comment 3 Gerrit Notification Bot 2014-05-02 18:03:39 UTC
Change 131074 merged by jenkins-bot:
ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted

https://gerrit.wikimedia.org/r/131074
Comment 4 Gerrit Notification Bot 2014-05-06 02:45:31 UTC
Change 131071 merged by jenkins-bot:
ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup

https://gerrit.wikimedia.org/r/131071
Comment 5 James Forrester 2014-05-06 02:45:56 UTC
Enough now that I'm going to call this done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links