Last modified: 2014-05-02 21:25:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66759, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64759 - OOjs UI: Auto-disabled tool group still responds to clicks
OOjs UI: Auto-disabled tool group still responds to clicks
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-02 18:25 UTC by Roan Kattouw
Modified: 2014-05-02 21:25 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-05-02 18:25:50 UTC
* Go to the tools demo
* Click "auto-disabling list"
* Click "click to disable this tool"
* "auto-disabling list" now appears greyed out
* Click "auto-disabling list"
* An active effect appears, even though the dropdown is disabled and you can't interact with it at all

Other disabled toolgroups don't have this problem, it's only the one that gets disabled dynamically.

This causes a bug in VisualEditor as well: click out of the editor (this disables most tools and auto-disables the Insert toolgroup), then click Insert. An active effect appears.
Comment 1 Gerrit Notification Bot 2014-05-02 19:27:05 UTC
Change 131120 had a related patch set uploaded by Trevor Parscal:
Use .isDisabled() instead of .disabled to support inheriting

https://gerrit.wikimedia.org/r/131120
Comment 2 Rainer Rillke @commons.wikimedia 2014-05-02 19:34:42 UTC
Is this a duplicate of Bug 64601 ?
Comment 3 Gerrit Notification Bot 2014-05-02 19:43:43 UTC
Change 131120 merged by jenkins-bot:
Use .isDisabled() instead of .disabled to support inheriting

https://gerrit.wikimedia.org/r/131120
Comment 4 James Forrester 2014-05-02 21:25:42 UTC
(In reply to Rainer Rillke @commons.wikimedia from comment #2)
> Is this a duplicate of Bug 64601 ?

No; bug 64434.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links