Last modified: 2014-06-05 02:30:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66762, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64762 - Opening many pages in succession breaks rendering
Opening many pages in succession breaks rendering
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
Android (alpha)
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-02 18:31 UTC by Dmitry Brant
Modified: 2014-06-05 02:30 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dmitry Brant 2014-05-02 18:31:33 UTC
If I keep following links in pages, and go about 5 or 6 pages deep, the WebView stops rendering the page properly (random blank rectangles, or a completely blank page).

If I go "back" in the stack of pages, they start rendering properly again.
Comment 1 Yuvi Panda 2014-05-02 18:34:52 UTC
So the problem is that we don't kill PageViewFragments when they aren't shown on screen - we add fragments than replace them. The reason being that I'm unclear about the lifecycle of fragments when they are in the activity's backstack but not visible. Also problematic is maintaining scroll position in the backstack. 

This ends up creating a lot of webviews! Terrible for our memory footprint and yes, this problem would happen. We need to figure out the lifecycle for those and handle 'back' properly.
Comment 2 Dan Garry 2014-05-02 18:36:28 UTC
I can't replicate this on my Nexus 7. I've clicked on about 30 links and everything's still working.
Comment 3 Dan Garry 2014-05-02 18:37:19 UTC
(In reply to Dan Garry from comment #2)
> I can't replicate this on my Nexus 7. I've clicked on about 30 links and
> everything's still working.

Er, I may have to take that back. Just as I submitted this comment, I clicked on another link and the screen went totally black.
Comment 4 Dmitry Brant 2014-05-02 19:04:20 UTC
I have the following devices, all of which exhibit this behavior after 6 pages:

Samsung Galaxy Note 2
Galaxy S3
Galaxy S4
Moto Droid
Comment 5 Dan Garry 2014-05-02 19:39:39 UTC
On my Nexus 7 it took around 35 pages for this to happen.
Comment 6 Gerrit Notification Bot 2014-05-02 19:47:43 UTC
Change 131130 had a related patch set uploaded by Dbrant:
Hiding page fragment when obscured by a new page.

https://gerrit.wikimedia.org/r/131130
Comment 7 Gerrit Notification Bot 2014-05-02 22:39:22 UTC
Change 131130 merged by jenkins-bot:
Hiding page fragment when obscured by a new page.

https://gerrit.wikimedia.org/r/131130
Comment 8 Yuvi Panda 2014-06-05 02:30:52 UTC
Should be fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links