Last modified: 2014-05-02 20:27:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66765, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64765 - [Regression] mediawiki.toc.js: show/hide toggle missing on many pages in wmf-production
[Regression] mediawiki.toc.js: show/hide toggle missing on many pages in wmf-...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.23.0
All All
: Normal major (vote)
: 1.24.0 release
Assigned To: Krinkle
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-02 19:31 UTC by Krinkle
Modified: 2014-05-02 20:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-05-02 19:31:51 UTC
https://en.wikipedia.org/wiki/New_Zealand_European


mw.loader.getState('mediawiki.toc')
"registered"

mw.loader.getVersion('mediawiki.toc')
"20140502T152855Z"

mw.loader.getVersion('mediawiki.util')
"20140501T184229Z"

mw.loader.moduleRegistry['mediawiki.util']
Object {version: 1398969749, dependencies: Array[3], group: null, source: "local", state: "ready"…}

mw.loader.moduleRegistry['mediawiki.util'].dependencies
["jquery.client", "jquery.mwExtension", "mediawiki.notify"]

mw.util.init
function (){util.$content=(function(){var i,l,$content,selectors;selectors=['.mw-body-primary','.mw-body','#bodyContent','#mw_contentholder','#article','#content','#mw-content-text','body'];for(i=0,
l=selectors.length;i<l;i++){$content=$(selectors[i]).first();if($content.length){return $content;}}return util.$content;})();}


As of https://github.com/wikimedia/mediawiki-core/commit/d7a40c8c8ae5b15907787443946d46cf77713e27#diff-a0826ebc584f93f08f0de55899ca3e89R197,

that should have "mediawiki.util" in its dependencies.

Looks like only half of that change got deployed. The init code from mw.util was removed, but the dependency never made it.
Comment 1 Krinkle 2014-05-02 19:35:57 UTC
For comparison, it should be:

mw.loader.getState('mediawiki.toc')
"ready"

And in the page html:

<script> .. mw.loader.load(["ext.cite","mediawiki.toc", ...
Comment 2 Krinkle 2014-05-02 19:41:43 UTC
So d7a40c8c8ae5b1590 moved it into a separate module and made it a dependency. That change did actually get deployed correctly.

Then later If0438b7b6f4649 changed it from a dependency for mediawiki.util in general to something added by the parser's module load queue. Which means that from that point on, not a single page globally has this module anymore until a full re-parse happens (which only happens when it is manually edited or purged).
Comment 3 Gerrit Notification Bot 2014-05-02 19:45:53 UTC
Change 131124 had a related patch set uploaded by Krinkle:
Restore mediawiki.toc dependency on mediawiki.util

https://gerrit.wikimedia.org/r/131124
Comment 4 Krinkle 2014-05-02 19:50:36 UTC
To reproduce: Browse around on en.wikipedia.org (logged-in or not, either is fine). For the the majority of pages were lacking the module.
Comment 5 Gerrit Notification Bot 2014-05-02 19:58:59 UTC
Change 131200 had a related patch set uploaded by Krinkle:
Restore mediawiki.toc dependency on mediawiki.util

https://gerrit.wikimedia.org/r/131200
Comment 6 Gerrit Notification Bot 2014-05-02 19:59:35 UTC
Change 131201 had a related patch set uploaded by Krinkle:
Restore mediawiki.toc dependency on mediawiki.util

https://gerrit.wikimedia.org/r/131201
Comment 7 Gerrit Notification Bot 2014-05-02 19:59:58 UTC
Change 131124 merged by jenkins-bot:
Restore mediawiki.toc dependency on mediawiki.util

https://gerrit.wikimedia.org/r/131124
Comment 8 Gerrit Notification Bot 2014-05-02 20:26:18 UTC
Change 131201 merged by jenkins-bot:
Restore mediawiki.toc dependency on mediawiki.util

https://gerrit.wikimedia.org/r/131201
Comment 9 Gerrit Notification Bot 2014-05-02 20:27:24 UTC
Change 131200 merged by jenkins-bot:
Restore mediawiki.toc dependency on mediawiki.util

https://gerrit.wikimedia.org/r/131200

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links