Last modified: 2014-06-26 23:30:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66826, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64826 - ResourceLoader: load.php requests with only=styles should report if module is missing
ResourceLoader: load.php requests with only=styles should report if module is...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal normal (vote)
: 1.24.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-04 14:33 UTC by Krinkle
Modified: 2014-06-26 23:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-05-04 14:33:34 UTC
Sometimes when messing locally with different things, a page might look broken.

Then I look at the response for a request like:

/load.php?debug=false&lang=en&modules=mediawiki.skinning.interface%7Cskins.vector.styles&only=styles&skin=vector&*

And it's near impossible to figure out that something is wrong. In this case, module "mediawiki.skinning.interface" could not be found.

debug=true makes no difference in this regard.

Had it been a regular request that isn't only=styles, it would've contained :

mw.loader.state({"mediawiki.skinning.interface":"missing"});

We should probably treat this the same as we do in case of exceptions and other errors in stylesheet requests, namely by prepending a comment to the response body.
Comment 1 Gerrit Notification Bot 2014-05-04 14:46:21 UTC
Change 131342 had a related patch set uploaded by Krinkle:
resourceloader: Report problematic modules in only=styles as well

https://gerrit.wikimedia.org/r/131342
Comment 2 Gerrit Notification Bot 2014-05-07 11:46:11 UTC
Change 131342 merged by jenkins-bot:
resourceloader: Report problematic modules in only=styles as well

https://gerrit.wikimedia.org/r/131342

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links