Last modified: 2014-07-16 10:28:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66842, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64842 - Gadgets not working
Gadgets not working
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major with 2 votes (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=8 s=2014-05-06
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-04 18:47 UTC by dacuetu
Modified: 2014-07-16 10:28 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description dacuetu 2014-05-04 18:47:41 UTC
Gadgets not working on Wikidata repo as reported here:
https://www.wikidata.org/wiki/Wikidata:Project_chat#Broken_gadgets_.28bis.29

Specially this one
https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js

But probably affects more of them.
Comment 1 Andre Klapper 2014-05-05 08:07:22 UTC
Any output in the browser error console (in most browsers under "Development tools", in IE it's pressing F12) when this happens?
Comment 2 Ayack 2014-05-05 08:44:29 UTC
With Firefox 30.0 beta, I've got this output on https://www.wikidata.org/wiki/Q980041

"Use of "addOnloadHook" is deprecated. Use jQuery instead." load.php:148
console.trace(): load.php:148
mw</<.log</log.warn() load.php:148
mw</<.log</log.deprecate</<.get() load.php:149
<anonyme> index.php:481

"Use of "addOnloadHook" is deprecated. Use jQuery instead." load.php:148
console.trace(): load.php:148
mw</<.log</log.warn() load.php:148
mw</<.log</log.deprecate</<.get() load.php:149
<anonyme> index.php:124

"Use of "addOnloadHook" is deprecated. Use jQuery instead." load.php:148
console.trace(): load.php:148
mw</<.log</log.warn() load.php:148
mw</<.log</log.deprecate</<.get() load.php:149
<anonyme> index.php:334

"Use of "addOnloadHook" is deprecated. Use jQuery instead." load.php:148
console.trace(): load.php:148
mw</<.log</log.warn() load.php:148
mw</<.log</log.deprecate</<.get() load.php:149
<anonyme> index.php:1502

ReferenceError: twttr is not defined
Trace de la pile :
tweetfilter_init@https://www.wikidata.org/wiki/Q980041:959:38
@https://www.wikidata.org/wiki/Q980041:971:3
 Q980041:966
Comment 3 Thiemo Mättig 2014-05-06 09:10:21 UTC
I spend a lot of time digging into this with not much success, unfortunately. There are a lot of smaller problems (like the event not being well defined and obviously firing way to early) and a big one: The AuthorityControl gadget assumes that all widgets are initialized. But that's exactly what we removed recently when working on bug 54098. I'm afraid the gadget must be completely rewritten from scratch.

@Ayack: You have a lot of user scripts in your common.js (which is fine). I think most (if not all) the messages you see are coming from these and are not connected to this report.
Comment 4 Lydia Pintscher 2014-05-16 14:52:27 UTC
It is fixed now except for some issues in Firefox. Those are handled in bug 65340.
Comment 5 dacuetu 2014-05-16 14:56:33 UTC
Doesn't work for me on Chrome... is it supposed to be deployed or do I have to wait?

On the console there is this warning (I don't know if related):
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.
Comment 6 Lydia Pintscher 2014-05-16 15:02:12 UTC
It is live. Can you purge the page?
Comment 7 dacuetu 2014-05-16 15:06:54 UTC
I tried purging and reloading several times on q76, with no result, this is the error I get now:

Exception thrown by ext.gadget.CommonsMedia load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Cl…:145
TypeError: undefined is not a function 
TypeError {stack: (...), message: "undefined is not a function"}
 load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Cl…:145
event.returnValue is deprecated. Please use the standard event.preventDefault() instead. load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Cl…:48
Comment 8 Lydia Pintscher 2014-05-16 15:10:22 UTC
Can reproduce on [[d:Q76]].
Comment 9 Thiemo Mättig 2014-05-16 17:28:55 UTC
(In reply to dacuetu from comment #7)
> Exception thrown by ext.gadget.CommonsMedia

Sorry for that. That was a mistake and is fixed.

Here is a simple proof that all default gadgets are fixed now:
https://www.wikidata.org/wiki/Q76?debug=1
So the remaining issue can not be in the gadgets. See bug 65340.
Comment 10 Ayack 2014-05-19 17:53:30 UTC
It's not fully fixed: there is still no link for P625 (coordinate location).

See: https://www.wikidata.org/wiki/Q914189?debug=1
Comment 11 Aude 2014-05-19 19:40:50 UTC
replied on the gadget talk page, with a suggested fix for coordinates.

https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#Broken_gadget

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links