Last modified: 2014-06-26 22:28:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66918, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64918 - Hash gets swallowed by Varnish redirect to mobile site
Hash gets swallowed by Varnish redirect to mobile site
Status: RESOLVED WORKSFORME
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-05 21:09 UTC by Jon
Modified: 2014-06-26 22:28 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-05-05 21:09:19 UTC
Go to https://en.m.wikipedia.org/wiki/Roekiah#Early_life on a mobile device. This doesn't take you to the section. It leaves you at the top of the page.

It didn't used to do this.
Comment 1 Bingle 2014-05-05 21:10:15 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9q49egRq
Comment 2 Ryan Kaldari 2014-05-13 00:09:51 UTC
I don't think it's a problem with the hash. If I try it with an h2 header, it works fine. It appears to only fail for sections that are collapsed.
Comment 4 Gerrit Notification Bot 2014-05-20 22:36:25 UTC
Change 133470 merged by jenkins-bot:
Respect the hash with sub headings

https://gerrit.wikimedia.org/r/133470
Comment 5 Maryana Pinchuk 2014-06-20 19:57:09 UTC
Sigh, it's back.

Steps to repro:

1. Google "wiring color codes" in Safari mobile browser on iPhone.
2. Follow the "Jump to "Colour code" link in the results.
3. Get taken to the top of the article instead of the color code section.
Comment 6 Jon 2014-06-20 20:08:47 UTC
I did write a browser test for this so you may want to check if that is failing...
Comment 7 Jon 2014-06-23 21:45:43 UTC
See features/toggling.feature
According to the test it's not broken.

Plus, when I follow those steps on my Android Chrome device it works for me.
If it's not working on an iPhone there might be another bug here.
Comment 8 Ryan Kaldari 2014-06-24 22:00:04 UTC
I wasn't able to reproduce, but I'm also not 100% clear on the reproduction steps. When I search for "wiring color codes" on en.wiki I don't get any results to click on. I tried using the original repro steps in Comment #1 and those seem to work OK (no bug apparent).
Comment 9 Ryan Kaldari 2014-06-26 18:57:50 UTC
I was able to reproduce by following the steps more closely. It looks like the hash is getting lost at the Varnish redirect level. Do you want to take a look at this Max?
Comment 10 Ryan Kaldari 2014-06-26 19:01:07 UTC
In other words, if I try to go to https://en.m.wikipedia.org/wiki/Earth#Shape directly, it works fine. But if I try to go to https://en.wikipedia.org/wiki/Earth#Shape on a mobile device, the hash gets lost and I'm redirected to https://en.m.wikipedia.org/wiki/Earth.
Comment 11 Ryan Kaldari 2014-06-26 19:04:24 UTC
According to Max, the problem here is that Varnish has no way of knowing the hash and this has always been a problem.
Comment 13 Jon 2014-06-26 20:07:12 UTC
you should really create a new bug in these circumstances. the original bug was about a JavaScript error. I seem to remember the varnish bug was recorded separately.
Comment 14 Max Semenik 2014-06-26 22:16:09 UTC
These are not the hashes you're looking for:P

In varnish's terminology, a hash is a cache key. What JS calls a hash is never passed to server.
Comment 15 Jon 2014-06-26 22:28:19 UTC
I'm closing this bug. See bug 50517 if you want to discuss this different issue. Original reported issue works fine.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links