Last modified: 2014-05-06 08:43:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66934, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64934 - Vector: Watch star should not remove focus outlint
Vector: Watch star should not remove focus outlint
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Krinkle
: accessibility
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-06 00:38 UTC by Krinkle
Modified: 2014-05-06 08:43 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
matma.rex: Backport_to_Stable+


Attachments

Description Krinkle 2014-05-06 00:38:15 UTC
When tabbing through the header on a regular page, each of the tabs reacts to focus using the browser default behaviour (on Mac this is often a blue outline).

When making it to the watch star, however, it's gone (there is a very subtle color change inside the star, but that's too subtle for focus, it's barely enough for hover).

There doesn't seem to be any reason for this (it's not explicitly removed from :focus, just from the element in general and :focus inherits it).

Fro the commit history, looks like this was added way back to deal with image outlines, but this has been refactored since and just forgotten.
Comment 1 Gerrit Notification Bot 2014-05-06 00:40:56 UTC
Change 131643 had a related patch set uploaded by Krinkle:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131643
Comment 2 Krinkle 2014-05-06 00:41:39 UTC
Recommending backport to 1.23.
Comment 3 Gerrit Notification Bot 2014-05-06 06:43:32 UTC
Change 131643 merged by jenkins-bot:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131643
Comment 4 Gerrit Notification Bot 2014-05-06 08:26:55 UTC
Change 131667 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131667
Comment 5 Gerrit Notification Bot 2014-05-06 08:36:20 UTC
Change 131667 merged by jenkins-bot:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131667

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links