Last modified: 2014-09-26 15:48:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66946, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64946 - WfTimestampTest::testOldTimestamps randomly fails for some users and on travis
WfTimestampTest::testOldTimestamps randomly fails for some users and on travis
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-06 09:24 UTC by Addshore
Modified: 2014-09-26 15:48 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Addshore 2014-05-06 09:24:11 UTC 
Particularly with data set #12 and #13. See https://travis-ci.org/wikimedia/mediawiki-core/jobs/24510844#L352 on travis

The method gets most of the date correct but gets the day itself slightly wrong.

To me this looks like something that changes slightly from system to system.

The tests (or these 2 in particular) should probably be changed to ignore the changing day and just test the rest of the timestamp.
Comment 1 Gerrit Notification Bot 2014-05-06 09:36:15 UTC 
Change 131674 had a related patch set uploaded by Addshore:
Ignore days of random failing tests in wfTimestampTest

https://gerrit.wikimedia.org/r/131674
Comment 2 Gerrit Notification Bot 2014-06-18 18:41:12 UTC 
Change 131674 merged by jenkins-bot:
Ignore days of random failing tests in wfTimestampTest

https://gerrit.wikimedia.org/r/131674
Comment 3 Fred Emmott 2014-09-26 15:48:32 UTC 
Not random - the old value in the test was incorrect; this was fixed in recent versions of PHP and HHVM (due to a timelib update). More info in https://github.com/wikimedia/mediawiki-core/pull/19
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links