Last modified: 2014-09-25 21:57:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67012, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65012 - VisualEditor: Switching to source mode should show a spinner, pending state or similar
VisualEditor: Switching to source mode should show a spinner, pending state o...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-09-18
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-07 19:02 UTC by Rummana Yasmeen
Modified: 2014-09-25 21:57 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2014-05-07 19:02:06 UTC
As of May 6th, I am experiencing a lag in switching from VE to Edit source mode, after clicking on Ok on "Switch to source editing" dialog, for 5-6 secs, it seems like nothing is happening on my browser. 

This is happening even if I have perfect network speed and all other things loading properly.
Comment 1 Roan Kattouw 2014-05-14 19:38:02 UTC
This is only in beta labs, probably because beta labs is just slow. We should have a spinner and a blocking overlay, though. Right now you can even interact with the surface while we switch to source mode.
Comment 2 Alex Monk 2014-07-05 19:21:59 UTC
Spinner? Hmm... I've been thinking perhaps mark the switch confirmation dialog as pending and just not close it.

As for blocking overlay... Not sure about what the best way to do that is yet. I assume setting pointer-events:none; on the <body> isn't great.
Comment 3 Gerrit Notification Bot 2014-07-07 20:00:21 UTC
Change 144505 had a related patch set uploaded by Alex Monk:
Show pending state and block clicks when switching to source mode

https://gerrit.wikimedia.org/r/144505
Comment 4 Gerrit Notification Bot 2014-09-16 23:44:24 UTC
Change 144505 merged by jenkins-bot:
Show pending state on action button and keep dialog open when switching to source mode

https://gerrit.wikimedia.org/r/144505
Comment 5 Rummana Yasmeen 2014-09-17 20:06:29 UTC
Verified the fix in Betalabs
Comment 6 Rummana Yasmeen 2014-09-18 23:10:41 UTC
Verified the fix in test2
Comment 7 Rummana Yasmeen 2014-09-25 21:57:57 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links