Last modified: 2014-05-08 20:28:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67020, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65020 - crashes in MW 1.21
crashes in MW 1.21
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-07 20:24 UTC by Lee Worden
Modified: 2014-05-08 20:28 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lee Worden 2014-05-07 20:24:23 UTC
It looks like the page load succeeds but a call to load.php fails.

The error message:

PHP Fatal error:  Call to undefined method ResourceLoaderGeSHiModule::getDefinitionMtime() in /usr/local/src/SyntaxHighlight_GeSHi/ResourceLoaderGeSHiModule.php on line 38
Comment 1 Bartosz Dziewoński 2014-05-07 23:23:34 UTC
The master branch has just undergone some modernization and is no longer compatible with MediaWiki versions older than 1.23 (which is a Release Candidate right now, due to be released in under a month). Is any documentation claiming otherwise? I'd like to fix it if so :)

You can download an older version of the extension compatible with your MediaWiki version via [[mw:Special:ExtensionDistributor/SyntaxHighlight_GeSHi]]).
Comment 2 Lee Worden 2014-05-07 23:35:38 UTC
https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi says 1.11+ - isn't that the main documentation?  :)

But actually it was the commit message at https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FSyntaxHighlight_GeSHi/b6d8b1a5b9a75a085d7d609db3524d99b99d345c that fooled me:

> The old way still works and is used for MediaWiki 1.20 and lower.

Which led me to think the new way works for 1.21 and up.

Unfortunately my WorkingWiki extension relies on SyntaxHighlight to highlight code, and I'd very much like to use the new RL-enabled SyntaxHighlight since I'm going over to retrieving files via AJAX, and would like to use RL to get the related resources, including css for syntax highlighting.  And my main user is on MW 1.21 for now...
Comment 3 Bartosz Dziewoński 2014-05-08 20:28:17 UTC
(In reply to Lee Worden from comment #2)
> > The old way still works and is used for MediaWiki 1.20 and lower.
> 
> Which led me to think the new way works for 1.21 and up.

Yeah, I was under the impression that what I did will work, but it turns out it doesn't :( I just updated the misleading documentation about the methods I used:  https://gerrit.wikimedia.org/r/132237

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links