Last modified: 2014-05-08 20:56:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67024, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65024 - sequence of cocontinue parameter does not yield full result set in action=query
sequence of cocontinue parameter does not yield full result set in action=query
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GeoData (Other open bugs)
master
Other Linux
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-07 22:17 UTC by Jonathan Pelletier
Modified: 2014-05-08 20:56 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jonathan Pelletier 2014-05-07 22:17:00 UTC
issuing the following query (and following the sequence of cocontinue parameters):

http://en.wikipedia.org/w/api.php?action=query&prop=coordinates&format=json&colimit=1&coprop=globe&coprimary=primary&titles=Montreal%7CParis%7CToronto%7CSherbrooke%7CQuebec

returns only 3 distinct coordinates whereas issuing the following query:

http://en.wikipedia.org/w/api.php?action=query&prop=coordinates&format=json&colimit=5&coprop=globe&coprimary=primary&titles=Montreal%7CParis%7CToronto%7CSherbrooke%7CQuebec

returns 5 distinct coordinates. The difference between the 2 queries is that the first uses a colimit=1 and the second uses a colimit=5. 

The returned result set Must be independent of whether or not the cocontinue mechanism was used to get the result. 

The queried API endpoint is http://en.wikipedia.org/w/api.php (dont know which version that is?).

Any feedback appreciated!
Comment 1 Brad Jorsch 2014-05-08 15:10:20 UTC
The prop=coordinates module is provided by the GeoData extension, reassigning there and confirming the bug.

At a glance, it looks like the bug is that the SQL query fragment for continuation is "gt_page_id > {$parts[0]} OR (gt_page_id = {$parts[0]} AND gt_id > {$parts[1]})" where it should have "gt_id >= {$parts[1]}" at the end instead.
Comment 2 Gerrit Notification Bot 2014-05-08 17:05:48 UTC
Change 132208 had a related patch set uploaded by MaxSem:
Fix prop=coordinates continuation

https://gerrit.wikimedia.org/r/132208
Comment 3 Gerrit Notification Bot 2014-05-08 20:26:20 UTC
Change 132208 merged by jenkins-bot:
Fix prop=coordinates continuation

https://gerrit.wikimedia.org/r/132208
Comment 4 Brad Jorsch 2014-05-08 20:28:58 UTC
The fix should be deployed to WMF wikis with 1.24wmf5, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule.
Comment 5 Jonathan Pelletier 2014-05-08 20:56:37 UTC
That was fast. Good work !

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links