Last modified: 2014-10-09 23:41:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67052, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65052 - VisualEditor: Put block slugs in the DM rather than fake them in CE
VisualEditor: Put block slugs in the DM rather than fake them in CE
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-10-16
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-09 07:44 UTC by Ed Sanders
Modified: 2014-10-09 23:41 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2014-05-09 07:44:37 UTC 
The concept of a block slug from a UX POV is great, but why do we need to keep them out of the DM? It seems to be the source of far too many getOffset hacks, as you can put your cursor somewhere that doesn't have a real offset (model-view inconsistency). We already have a way of marking a paragraph as to-be-ignored-by-the-converter-if-empty ({internal:'empty'}), so let's just put them in the DM, and throw them away at convert time if they're empty.
Comment 1 Ed Sanders 2014-05-09 07:54:03 UTC 
Also if we do this we can force the SurfaceObserver to always move cursor positions to content offsets (except for FocusableNodes) which should prevent bugs like Firefox select-all giving you [0,data.length].
Comment 2 Gerrit Notification Bot 2014-07-31 00:49:22 UTC 
Change 135131 had a related patch set uploaded by Jforrester:
Stage slugs

https://gerrit.wikimedia.org/r/135131
Comment 3 Gerrit Notification Bot 2014-08-01 18:52:56 UTC 
Change 135131 had a related patch set uploaded by Catrope:
Stage slugs

https://gerrit.wikimedia.org/r/135131
Comment 4 Gerrit Notification Bot 2014-10-09 23:37:35 UTC 
Change 135131 merged by jenkins-bot:
Stage slugs

https://gerrit.wikimedia.org/r/135131
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links