Last modified: 2014-05-19 19:12:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67071, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65071 - Move ApiQueryRecentChanges::parseRCType to static method on RecentChange
Move ApiQueryRecentChanges::parseRCType to static method on RecentChange
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: 1.24.0 release
Assigned To: Kishan Thobhani (kishanio)
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-09 14:03 UTC by Ori Livneh
Modified: 2014-05-19 19:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2014-05-09 14:03:21 UTC 
We should provide a public interface for mapping RC_* constants to human-readable descriptions (e.g. RC_EDIT => "edit"). ApiQueryRecentChanges::parseRCType() does this, but it is a private method, and it is on the wrong class -- there is nothing API-specific about this functionality.
Comment 1 Brad Jorsch 2014-05-09 19:48:16 UTC 
There's also a duplicate of this function in ApiWatchlist.
Comment 2 Brad Jorsch 2014-05-09 19:50:47 UTC 
Actually, ApiQueryRecentChanges::parseRCType() does the opposite, parsing text to RC_* constants. But both ApiQueryRecentchanges and ApiWatchlist implement both both, the latter is just embedded in the middle of their extractRowInfo() functions.
Comment 3 Gerrit Notification Bot 2014-05-15 10:26:44 UTC 
Change 133441 had a related patch set uploaded by Kishanio:
Move ApiQueryRecentChanges::parseRCType to static method on RecentChange

https://gerrit.wikimedia.org/r/133441
Comment 4 Gerrit Notification Bot 2014-05-19 18:57:28 UTC 
Change 133441 merged by jenkins-bot:
Move ApiQueryRecentChanges::parseRCType to static method on RecentChange

https://gerrit.wikimedia.org/r/133441
Comment 5 Umherirrender 2014-05-19 19:12:47 UTC 
was successfully merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links