Last modified: 2014-07-15 00:15:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67073, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65073 - CPB: compactPersonalBar.js breaks mw.util.addPortletLink for gadgets, user scripts and other extensions
CPB: compactPersonalBar.js breaks mw.util.addPortletLink for gadgets, user sc...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
VectorBeta (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://github.com/wikimedia/mediawik...
: easy, javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-09 14:31 UTC by Helder
Modified: 2014-07-15 00:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2014-05-09 14:31:54 UTC
There is an incompatibility between this is the (global) [[MediaWiki:Gadget-UTCLiveClock.js]]. The clock/purge link disappeared as soon as this feature went live.

PS: I got an error when I tried to send this message on
https://www.mediawiki.org/wiki/Talk:Compact_Personal_Bar
<blockquote>
Ocorreu um erro.
A mensagem de erro recebida é a seguinte: Exception Caught: Attempted to compact row containing objects, must be scalar values: Flow\Model\UUID Object ( [binaryValue:protected] => ��횺|q�xJQ [hexValue:protected] => 0513ed9aba7c711b784a51 [alphadecimalValue:protected] => rrn2mhn8pm8qtrgx [timestamp:protected] => ) </blockquote>
and then
<blockquote>
A mensagem de erro recebida é a seguinte: Exception Caught: Failed contacting Parsoid
</blockquote>
Moreover, it is really difficult to find a reply button on that Flow talk page =/
Comment 1 Jared Zimmerman (WMF) 2014-05-09 15:37:49 UTC
Does anyone know who maintains this gadget? I couldn't find a project page
Comment 2 Helder 2014-05-09 16:50:47 UTC
I remember Krinkle did a big update to the gadget some years ago, when ResourceLoader was introduced (MW 1.17?). Maybe he could take a look?
Comment 3 Helder 2014-07-14 23:57:47 UTC
Copying my comments from
https://gerrit.wikimedia.org/r/#/c/99586/10/resources/compactPersonalBar/compactPersonalBar.js,unified
[The $li from line 71] is not being used. $li should store the 'li' returned by the createItem(...) call which is a few lines below. That would probably fix bug 65073.

[On line 89 it ] should return $li[0] as in https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki/mediawiki.util.js#L343
Comment 4 Krinkle 2014-07-15 00:13:54 UTC
Yeah, the overloaded version of addPortletLink:

* creates a phoney <a> and <li> that are not used anywhere.
* returns a jQuery object instead of DOM element.
* does not return the element shown in the document, as a result gadgets
  using the reference to bind event handlers (e.g. a link like <a href="#"> is
  quite common to be put in a portlet link), are broken.


Raising priority to emphasise that CPB can't go opt-out / enabled by default before this bug is fixed as it would result in wide scale breakage.
Comment 5 Krinkle 2014-07-15 00:15:22 UTC
Note that this is not limited to power users. Lots of site scripts and gadgets are enabled by default on wikis now. And both anonymous users and new logged-in users make use of their functionality which is rendered unusable by this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links