Last modified: 2014-08-22 14:31:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67085, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65085 - jenkins on release branch has problem when patch set contains js files


Summary:	jenkins on release branch has problem when patch set contains js files

Status:	NEW

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-09 17:54 UTC by Umherirrender
Modified:	2014-08-22 14:31 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2014-05-09 17:54:27 UTC

Gerrit change #132181 is a backport to REL1_22, but jenkins get stucked with the js files, because jsduck and npm jobs are failing.

Errors:

ln: failed to create symbolic link `/srv/ssd/jenkins-slave/workspace/mediawiki-core-jsduck/docs/js/modules': No such file or directory

cd: /mnt/jenkins-workspace/workspace/mediawiki-core-npm/tests/frontend: No such file or directory

Please have a look and fix jenkins config to allow merging of patch sets with js files on release branches. Thanks.

Comment 1 Mark A. Hershberger 2014-05-09 18:08:40 UTC

Pinging Antoine on this Jenkins issue.

Comment 2 Antoine "hashar" Musso (WMF) 2014-08-19 14:52:44 UTC

Check with Timo.  Apparently both npm and jsduck jobs are failing on REL1_22 and previous.  I guess we will want a branch filter in Zuul to prevent triggering of those jobs on our old releases.

Comment 3 Krinkle 2014-08-21 19:00:14 UTC

Indeed. For pre-1.23 builds, resort to the global install of jshint (the same job we use for the 'check' pipeline of mediawiki-core, mediawiki-core-jshint).

The local set up with package.json and Gruntfile didn't exist yet back then.

Comment 4 Antoine "hashar" Musso (WMF) 2014-08-22 14:31:01 UTC

From Zuul configuration it seems jsduck used to work on REL1_22:

  - name: mediawiki-core-jsduck
    branch: ^(REL1_21|REL1_22|REL1_23|master)$

  - name: mediawiki-core-jsduck-publish
    branch: ^(REL1_21|REL1_22|REL1_23|master)$

So that would be a regression somewhere.



Should we prevent mediawiki-core-npm from running on REL1_22 ?  Will just have to do something like:


    - name: ^mediawiki-core-npm$
+     branch: (?!REL1_22)
      files:
       - '^(\.js.*|.*\.(js|json)$)'

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links