Last modified: 2014-05-09 18:52:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67086, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65086 - SpecialDisambiguationPages doesn't respect table prefixes
SpecialDisambiguationPages doesn't respect table prefixes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Disambiguator (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-09 17:58 UTC by Florian
Modified: 2014-05-09 18:52 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screen Capture of db error (39.41 KB, image/png)
2014-05-09 17:58 UTC, Florian
Details

Description Florian 2014-05-09 17:58:52 UTC
Created attachment 15325 [details]
Screen Capture of db error

A database error occur, when you open the Special Page of DISAMBIG, here the error details:

Query:
SELECT page_props.pp_page AS value,page.page_namespace AS namespace,page.page_title AS title FROM `wiki_page`,`wiki_page_props` WHERE (page_id = pp_page) AND pp_propname = 'disambiguation' AND (page_namespace != 10) ORDER BY value LIMIT 51

function:
SpecialDisambiguationPages::reallyDoQuery

Error:
1054 Unknown column 'page_props.pp_page' in 'field list' (localhost)
(yes, without prefix)

If i'm right, a hotfix is:
Edit file: SpecialDisambiguationPages.php
find "'fields' => array("
delete table prefix "page_props" and "page"

Not tested on other wikis!

Wiki-Data:
URL droidwiki.de
MediaWiki	1.24wmf2
PHP	5.5.3-1ubuntu2.3 (apache2handler)
MySQL	5.5.37-0ubuntu0.13.10.1

Testwiki (not fixed):
http://wiki.go2tech.de/Spezial:Begriffsklärungsseiten
Thanks for fix!
Comment 1 Sam Reed (reedy) 2014-05-09 18:00:23 UTC
1.24wmf2 is out of date. I'd suggest upgrading to 1.24wmf4...
Comment 2 Sam Reed (reedy) 2014-05-09 18:02:19 UTC
wmf3 works at least https://en.wikipedia.org/wiki/Special:DisambiguationPages
Comment 3 Sam Reed (reedy) 2014-05-09 18:03:28 UTC
Oh, ignore me. It needs the prefixing fixing
Comment 4 Gerrit Notification Bot 2014-05-09 18:05:32 UTC
Change 132474 had a related patch set uploaded by Reedy:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132474
Comment 5 Florian 2014-05-09 18:10:30 UTC
Applied patch -> working

Info only:
You are right, sorry, i missed two updates, wasn't good to open bug before ensure the newest git version (when not use the official release branch). I have updated and the error was the same, like you know, but after patch it work :)
Comment 6 Jesús Martínez Novo (Ciencia Al Poder) 2014-05-09 18:14:16 UTC
Patch hasn't been merged yet, but thanks for verifying it's working!

It should also be backported to REL1_23 (and older?) branch once merged.
Comment 7 Gerrit Notification Bot 2014-05-09 18:32:41 UTC
Change 132474 merged by jenkins-bot:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132474
Comment 8 Gerrit Notification Bot 2014-05-09 18:34:13 UTC
Change 132481 had a related patch set uploaded by Reedy:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132481
Comment 9 Gerrit Notification Bot 2014-05-09 18:34:26 UTC
Change 132482 had a related patch set uploaded by Reedy:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132482
Comment 10 Gerrit Notification Bot 2014-05-09 18:49:41 UTC
Change 132481 merged by jenkins-bot:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132481
Comment 11 Gerrit Notification Bot 2014-05-09 18:49:46 UTC
Change 132482 merged by jenkins-bot:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132482
Comment 12 Max Semenik 2014-05-09 18:52:02 UTC
Stupid bot.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links