Last modified: 2014-07-17 01:48:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67087, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65087 - cssclass option does not apply class to help text
cssclass option does not apply class to help text
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
HTMLForm (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-09 18:41 UTC by Zell Faze
Modified: 2014-07-17 01:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch that fixes bug 65087 (2.50 KB, patch)
2014-05-09 19:15 UTC, Zell Faze
Details

Description Zell Faze 2014-05-09 18:41:37 UTC
When adding a CSS class to an HTMLForm element using the "cssclass" option the class is not applied to the text that is displayed below the element that is provided in the "help" option.

This is counter-intuitive and if the cssclass option is not applied to the help text a separate option should be provided to allow the styling of the help text.
Comment 1 Zell Faze 2014-05-09 19:15:09 UTC
Created attachment 15326 [details]
Patch that fixes bug 65087

Uploaded a patch that adds an option to allow styling of the help text.  This is my first patch to Mediawiki and I don't have Gerrit access, so I am uploading it here instead.
Comment 2 Andre Klapper 2014-05-12 09:54:14 UTC
Hi! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again! We appreciate your contribution.
Comment 3 Gerrit Notification Bot 2014-05-12 14:27:26 UTC
Change 132946 had a related patch set uploaded by Gerrit Patch Uploader:
Adding css styling option for help option in HTMLForm

https://gerrit.wikimedia.org/r/132946
Comment 4 Andre Klapper 2014-05-12 17:32:43 UTC
Thanks!
Comment 5 Zell Faze 2014-07-16 14:02:02 UTC
Uploaded a new patch.  Mentioning here since I noticed that the Gerrit Notification Bot didn't.  Just corrects the issues with the previous patch.
Comment 6 Gerrit Notification Bot 2014-07-16 23:22:03 UTC
Change 132946 merged by jenkins-bot:
Adding css styling option for help option in HTMLForm

https://gerrit.wikimedia.org/r/132946

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links