Last modified: 2014-08-20 00:51:59 UTC
Introduced in I04cdee7b83e2b1c3503f4b73c902d08ec7028904 I believe. I have a unique-ish setup, in which my `origin` remote points to either the github repo, or the https://gerrit.wikimedia.org repo, and the `gerrit` remote is over ssh. I do this since my school blocks ssh to gerrit since it uses a non-standard port (that's another bug somewhere), so I always pull through `origin`. Now whenever I run $ vagrant provision; it "fixes" my remotes, which leaves my setup broken. There should be some kind of option to leave the remotes alone. I tried leaving my username blank (as the prompt claims this would do it "anonymous"-ly), but that left it in an even more broken state, pointing to "ssh://@gerrit.wikimedia.org:29418/mediawiki/extensions/Flow.git"
looking... seems the user='' is broken
Anonymous git user should be fixed with Change-Id: I16eb918f21eee23c0fb933744b1ae58c4813db6f Would anonymous https://gerrit.wikimedia.org fix your issue?
It would fix my current issue, but really vagrant shouldn't be changing my remotes unless I explicitly ask for it.
The fix has been merged. I have altered the code to change remotes only if $remote parameter is not given in the clone parameters. This won't be very useful just yet (all callers of the clone object use default remote), so we could later alter it a bit further to introduce a global flag which also prevents this. I will leave it up to Ori to decide this one.
It makes sense that if you're actually cloning a new repo that vagrant defines the remote to use, but in my case the repositories already exist. I fail to see why changing the remotes is even necessary or should be done at all.
The manipulation of git remotes was reverted. Yuri continues to work on getting the feature back in, but I'm with Kunal that existing git clones should not be touched. The number of people this will be harmful/confusing for outweighs the number it would help in my opinion.
