Last modified: 2014-05-14 23:52:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67118, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65118 - Device detection code doesn't detect MSIE 11


Summary:	Device detection code doesn't detect MSIE 11

Status:	RESOLVED FIXED

Product:	MobileFrontend
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-10 08:51 UTC by Liangent
Modified:	2014-05-14 23:52 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2014-05-10 08:51:40 UTC

See http://msdn.microsoft.com/en-us/library/ie/hh869301%28v=vs.85%29.aspx

includes/DeviceDetection.php-				$deviceName = 'netfront';
includes/DeviceDetection.php-			}
includes/DeviceDetection.php:		} elseif ( strpos( $userAgent, 'MSIE' ) !== false ) {
includes/DeviceDetection.php-			$deviceName = 'ie';
includes/DeviceDetection.php-		}
--
javascripts/common/mf-application.js-			// any Firefox
javascripts/common/mf-application.js-			/Firefox/,
javascripts/common/mf-application.js:			// MSIE 10+
javascripts/common/mf-application.js:			/MSIE 1\d/
javascripts/common/mf-application.js-		].forEach( function( item ) {
javascripts/common/mf-application.js-			if ( item.test( navigator.userAgent ) ) {

Comment 1 Bingle 2014-05-10 08:55:14 UTC

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JeFdAiDn

Comment 2 Brion Vibber 2014-05-10 09:04:13 UTC

Here's some sample UAs for IE 11:

Windows 8.1 x64 desktop:
Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko

Windows 8.1 x64 metro:
Mozilla/5.0 (Windows NT 6.3; Win64; x64; Trident/7.0; rv:11.0) like Gecko

Windows Phone 8.1 x64 (emulator, my device is in other room):
Mozilla/5.0 (Windows Phone 8.1; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; Microsoft; Virtual) like Gecko

Comment 3 Brion Vibber 2014-05-10 09:24:14 UTC

Basically we want to detect the 'Trident' tag and find the 'rv:11.0' to extract the version.

Comment 4 Max Semenik 2014-05-10 16:21:08 UTC

Note that the DeviceDetection.php code from this bug report is outdated as we don't have that check anymore and mobileness check stll works properly as IE mobile 11's UAs still contain the word 'mobile'.

Comment 5 Liangent 2014-05-13 07:46:59 UTC

if I read correctly position: fixed check is still not covered.

Comment 6 Liangent 2014-05-13 15:54:34 UTC

Actually I guess we should get rid of any home made scripts here and turn to use jquery.client.

Comment 7 Gerrit Notification Bot 2014-05-13 16:29:29 UTC

Change 133088 had a related patch set uploaded by Jdlrobson:
Support position fixed on Trident (newer IE versions)

https://gerrit.wikimedia.org/r/133088

Comment 8 Gerrit Notification Bot 2014-05-14 21:05:38 UTC

Change 133088 merged by jenkins-bot:
Cleanup and improve supportsPositionFixed

https://gerrit.wikimedia.org/r/133088

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links