Last modified: 2014-09-26 22:07:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67140, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65140 - Prevent the addition of files with names that aren't supported on Windows
Prevent the addition of files with names that aren't supported on Windows
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-10 15:06 UTC by Umherirrender
Modified: 2014-09-26 22:07 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2014-05-10 15:06:46 UTC
A colon in a file name is forbidden on a windows machine.
When a repository contains one or more files with a colon in its name, cloning of that repository fails.

Please add a pre commit hook to avoid adding files with a colon in its name.
Maybe there are more letters to ignore. Thanks.
Comment 1 Bartosz Dziewoński 2014-09-22 18:09:52 UTC
I wonder if this wouldn't be better implemented as a linter? I remember this was also a problem when there were files named like '*.wikimedia.org' that had something to do with the domains somewhere in operations repo.

The following characters are not allowed in Windows file names:

  \ / : * ? " < > |

Note both kinds of slashes as directory separators.
Comment 2 Antoine "hashar" Musso (WMF) 2014-09-22 18:55:00 UTC
The issue is affected CommonsMetadata (bug 65139).  I am not sure it is worth triggering a job for every single patchset being sent just to catch it.
Comment 3 Greg Grossmeier 2014-09-26 22:07:59 UTC
This could be something added to Arcanist when we switch to Phabricator for code review.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links