Last modified: 2014-06-12 19:09:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67143, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65143 - Flow: <br> changes to &lt;br&gt; if you edit
Flow: <br> changes to &lt;br&gt; if you edit
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 65975 66189 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-10 15:23 UTC by Jared Zimmerman (WMF)
Modified: 2014-06-12 19:09 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jared Zimmerman (WMF) 2014-05-10 15:23:09 UTC
in Flow when you add <br> and save a post it is replaced with &lt;br&gt; it renders fine initially but if edited and saved again, will then render as &lt;br&gt; as plain text.
Comment 1 Jared Zimmerman (WMF) 2014-05-10 15:26:26 UTC
it actually seems like other html tags do this too like <small></small>
Comment 2 Gerrit Notification Bot 2014-05-12 18:31:42 UTC
Change 132969 had a related patch set uploaded by EBernhardson:
Don't expand templates inside topic titles

https://gerrit.wikimedia.org/r/132969
Comment 3 Quiddity 2014-05-12 22:18:32 UTC
Additional comment from Jay8g: "In the page header, some symbols are escaped when you edit the header. It saves normally the first time, but further edits break it."

I recall a similar "2nd edit" bug from many months ago, but can't find it.
Comment 4 Gerrit Notification Bot 2014-05-12 23:02:21 UTC
Change 133031 had a related patch set uploaded by EBernhardson:
Prevent double escape of content to be edited

https://gerrit.wikimedia.org/r/133031
Comment 5 Gerrit Notification Bot 2014-05-16 21:16:00 UTC
Change 132969 merged by jenkins-bot:
Don't expand templates inside topic titles

https://gerrit.wikimedia.org/r/132969
Comment 6 spage 2014-05-27 20:58:32 UTC
(In reply to Quiddity from comment #3)
> Additional comment from Jay8g: "In the page header, some symbols are escaped
> when you edit the header. It saves normally the first time, but further
> edits break it."

Your initial title edit works, after you save you see exactly what you typed with no parsing on page, watchlist, history, etc.

But
a) the title [Preview] parses some HTML, you get a line break in place of <br> and see italics in place of <em>.
b) As reported in comment #3, if you edit the title, HTML entities like < and > are incorrectly transformed into &lt; and &gt;.
Comment 7 bsitu 2014-05-29 23:42:53 UTC
Patch to review: https://gerrit.wikimedia.org/r/#/c/133031/
Comment 8 Quiddity 2014-05-31 19:11:58 UTC
*** Bug 65975 has been marked as a duplicate of this bug. ***
Comment 9 spage 2014-06-05 17:56:58 UTC
*** Bug 66189 has been marked as a duplicate of this bug. ***
Comment 10 Gerrit Notification Bot 2014-06-05 21:32:59 UTC
Change 133031 merged by jenkins-bot:
Prevent double escape of content to be edited

https://gerrit.wikimedia.org/r/133031
Comment 11 spage 2014-06-12 19:09:15 UTC
Editing in JavaScript is fixed, but entities are still double-escaped in no-JS (bug 66227) and in placeholder text for a comment on a topic (bug 66547).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links