Last modified: 2014-08-15 21:14:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67286, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65286 - #p-logo should be at the top of <body>
#p-logo should be at the top of <body>
Status: NEW
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-14 06:30 UTC by Ori Livneh
Modified: 2014-08-15 21:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-05-14 06:30:00 UTC
On an image-heavy page like https://en.wikipedia.org/wiki/Switzerland, browsers hit the limit of maximum concurrent connections. It takes a very long time before all images are retrieved. This fact could have been made invisible if the assets required for rendering the top portion of the page were loaded first. Instead, we load the logo last, so it appears very late, and when it does it causes a reflow of the sidebar. Blech.
Comment 1 Bartosz Dziewoński 2014-05-14 12:03:02 UTC
This could be solved by doing something like https://gerrit.wikimedia.org/r/#/c/98356/ (basically creates a separate RL module for the logo – still pending review :( ) and setting the new module to position=>top?
Comment 2 Bartosz Dziewoński 2014-08-15 21:13:40 UTC
On second thought, maybe we should actually put #p-logo at the beginning of page HTML… I ended up doing that in [[mw:Skin:Example]] as a simple, sane way of rendering the logo.

All other things equal, we should probably figure out which is the best from accessibility standpoint. A <img src=… alt="{{SITENAME}} logo"> instead of the weirdness we have now might actually make sense?
Comment 3 Bartosz Dziewoński 2014-08-15 21:14:28 UTC
(I'm going to move this to Vector component because I bet no one wants to change all other skins. Many of them don't even display the logo.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links