Last modified: 2014-11-06 00:41:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67310, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65310 - VisualEditor: The "Review your changes" button should be disabled when save dialog is busy
VisualEditor: The "Review your changes" button should be disabled when save d...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-11-12 (1.25wmf8)
Assigned To: Alex Monk
:
: 65485 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-14 20:37 UTC by Rummana Yasmeen
Modified: 2014-11-06 00:41 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (60.42 KB, image/png)
2014-05-14 20:37 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-05-14 20:37:13 UTC 
Created attachment 15385 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Make some edit
3.Click on Save Page on the Save page dialog
4.While loading bar is in progress click on "Review your changes"


Observed Result:
It opens up the Review section while the loading bar is still showing up above and below the dialog.

Environment:Betalabs,test2 and production
Comment 1 Krinkle 2014-05-19 13:50:26 UTC 
*** Bug 65485 has been marked as a duplicate of this bug. ***
Comment 2 Alex Monk 2014-08-24 01:10:05 UTC 
It doesn't do anything while the dialog is pending now. Should we be marking it as disabled though?
Comment 3 Gerrit Notification Bot 2014-11-05 23:34:37 UTC 
Change 171474 had a related patch set uploaded by Alex Monk:
Disable review button while save dialog is pending

https://gerrit.wikimedia.org/r/171474
Comment 4 Gerrit Notification Bot 2014-11-06 00:35:19 UTC 
Change 171474 merged by jenkins-bot:
Disable review button while save dialog is pending

https://gerrit.wikimedia.org/r/171474
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links