Last modified: 2014-05-22 21:39:33 UTC
Created attachment 15386 [details] Screenshot Steps to reproduce: 1.Go to this page:http://en.wikipedia.beta.wmflabs.org/wiki/14thmaychrome?veaction=edit 2.Select the image on the page 3.Go to Media Settings>Advanced Settings>Image Size 4.Change the tab from Default to custom or Custom to Default Observed Result: The "Make full size" button remains disabled for the image See the screenshot attached
Found the steps to reproduce: 1.Insert any image 2.Go to Media Settings>Advanced Settings 3.Select Custom tab and change the values 4.Apply changes 5.Save the page 6.Reopen the page 7.Go to the Media Settings>Advanced Settings of that image again Observed Result: The "Make full size" button became disabled ,switching tabs/changing values again does not make it enabled anymore.
It seems likely that this is due to cache pollution of the promise cache introduced in https://gerrit.wikimedia.org/r/#/c/132207/4/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js . The bug only happens when saving then reopening the editor in the same session without navigating away.
Change 133384 had a related patch set uploaded by Catrope: Revert "Cache image scalable promises by filename" https://gerrit.wikimedia.org/r/133384
Change 133384 merged by jenkins-bot: Revert "Cache image scalable promises by filename" https://gerrit.wikimedia.org/r/133384
Verified the fix in Betalabs
Verified the fix in test2
Verified the fix in production
