Last modified: 2014-07-10 21:05:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67326, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65326 - VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden
VisualEditor Mobile: Tapping on a link redirects to the link target page in S...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Mobile (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-03
Assigned To: Ed Sanders
:
: 66559 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-15 00:40 UTC by Rummana Yasmeen
Modified: 2014-07-10 21:05 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Link is followed (kind of) (1.11 MB, video/quicktime)
2014-06-23 21:44 UTC, Juliusz Gonera
Details

Description Rummana Yasmeen 2014-05-15 00:40:28 UTC
Steps to reproduce:

1.Open a page with VE that has link inside it.
2.Tap on any link 

Observed Result:
The browser page gets redirected to the link target page

Test Environment: https://en.m.wikipedia.org/
Device: iPad Mini
Comment 1 Juliusz Gonera 2014-06-23 21:43:33 UTC
This bug happens on any iOS Safari probably. The link doesn't seem to go to the destination in some cases (in my dev instance it goes to 127.0.0.1 even though I loaded the page from an external IP).

More importantly, this seems to be happening only when the keyboard is hidden (contenteditable is not focused). See attached video.

I tested it on iOS 7.1.1. It doesn't happen on Chrome for Android.
Comment 2 Juliusz Gonera 2014-06-23 21:44:01 UTC
Created attachment 15705 [details]
Link is followed (kind of)
Comment 3 Juliusz Gonera 2014-06-23 22:01:20 UTC
Jon has never worked on this bug.
Comment 4 James Forrester 2014-06-24 01:24:50 UTC
Pushing to Ed because it appears to be a shield/highlight issue.
Comment 5 Juliusz Gonera 2014-06-24 23:24:28 UTC
*** Bug 66559 has been marked as a duplicate of this bug. ***
Comment 6 Rummana Yasmeen 2014-06-27 18:50:48 UTC
This bug did not resolved by :

FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260
Comment 7 Rummana Yasmeen 2014-06-27 18:51:19 UTC
did not get*
Comment 8 Ed Sanders 2014-06-30 20:38:16 UTC
Links don't have any custom highlights (and shields no longer exist) so this must just be a CE bug in iOS (should be filed upstream if possible). We don't even have event listeners on links at the moment but we might have to add some as a work around
Comment 9 James Forrester 2014-06-30 20:39:23 UTC
(In reply to Ed Sanders from comment #8)
> We don't even have event listeners on links at the moment but we might have to
> add some as a work around

Eww. If we do, let's keep it as local as possible (mobile-only, for instance).
Comment 10 Gerrit Notification Bot 2014-06-30 21:00:08 UTC
Change 143152 had a related patch set uploaded by Esanders:
Prevent iOS Safari from following links

https://gerrit.wikimedia.org/r/143152
Comment 11 Gerrit Notification Bot 2014-07-01 19:36:02 UTC
Change 143152 merged by jenkins-bot:
Prevent iOS Safari from following links

https://gerrit.wikimedia.org/r/143152
Comment 12 Rummana Yasmeen 2014-07-02 00:31:41 UTC
Verified the fix in Betalabs
Comment 13 Rummana Yasmeen 2014-07-07 23:05:27 UTC
Verified the fix in test2
Comment 14 Rummana Yasmeen 2014-07-10 21:05:44 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links