Last modified: 2014-10-09 21:48:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67353, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65353 - VisualEditor: Blue link / red link logic should descend into links inside transclusions
VisualEditor: Blue link / red link logic should descend into links inside tra...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2014-10-09
Assigned To: Alex Monk
:
: 65355 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-15 18:10 UTC by Trevor (Wikia)
Modified: 2014-10-09 21:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Trevor (Wikia) 2014-05-15 18:10:18 UTC
Redlinks are displayed as blue links in templates inside the VisualEditor


https://en.wikipedia.org/wiki/Javier_Payo?veaction=edit
Comment 1 James Forrester 2014-05-15 18:23:04 UTC
*** Bug 65355 has been marked as a duplicate of this bug. ***
Comment 2 Krinkle 2014-09-24 21:23:39 UTC
We used to parse template content with action=parse from the PHP parser which naturally contained <a class="new">.

Nowadays we use Parsoid for the generated fragments as well, but this meant we lost the natural classes MediaWiki provided.

The mw.LinkCache logic should extend to the nodes inside generated content.

I think right now this isn't done because we use the same DOM for both the DM and the CE of generated content nodes, but, just as we do for practically everything else, it shouldn't be an issue to have our copy in CE be different from the copy in DM (thus not having to worry about needing to strip any classes when saving back to Parsoid).
Comment 3 Gerrit Notification Bot 2014-10-07 20:02:31 UTC
Change 165240 had a related patch set uploaded by Alex Monk:
Apply link styling logic to transclusion nodes

https://gerrit.wikimedia.org/r/165240
Comment 4 Gerrit Notification Bot 2014-10-08 14:30:04 UTC
Change 165240 merged by jenkins-bot:
Apply link styling logic to transclusion nodes

https://gerrit.wikimedia.org/r/165240
Comment 5 Alex Monk 2014-10-08 16:58:23 UTC
Transclusion nodes are not the only generated content nodes
Comment 6 James Forrester 2014-10-08 18:00:46 UTC
(In reply to Alex Monk from comment #5)
> Transclusion nodes are not the only generated content nodes

They are, however, almost exclusively the GCNs with wikitext links in them. Do we actually care about <easytimeline> blocks?
Comment 7 Alex Monk 2014-10-08 18:05:47 UTC
Well, it was you who changed this bug from being about just templates to being about "generated content nodes (e.g. templates)"... We can just make it about templates only again if you want.
Comment 8 James Forrester 2014-10-09 21:48:00 UTC
(In reply to Alex Monk from comment #7)
> Well, it was you who changed this bug from being about just templates to
> being about "generated content nodes (e.g. templates)"... We can just make
> it about templates only again if you want.

Created that as bug 71900.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links