Last modified: 2014-06-06 19:29:24 UTC
See design mock-up at https://trello.com/c/xCo6uLAZ/9-5-references-dropdown-from-toolbar-styling. Right now, I can give a popupToolGroup a label by using the 'label' param in a toolbarGroup definition: { 'label': 'Cite', 'type': 'list', 'icon': 'reference', 'title': OO.ui.deferMsg( 'visualeditor-toolbar-cite-label' ), 'include': [ { 'group': 'cite' } ] } However, this puts the label above the popup (in the popupToolGroup-handle) rather than within the popup itself (as needed by the design linked to above). I can imagine two different ways of providing this functionality: 1. Add a new type of param for toolbarGroups called something like 'inner-label' 2. Allow creating non-functional labels from the on-wiki group definition, for example: [ { "label": "cite" }, { "name": "web", "icon": "ref-cite-web", "template": "Cite web" }, { "name": "book", "icon": "ref-cite-book", "template": "Cite book" }, { "name": "news", "icon": "ref-cite-news", "template": "Cite news" }, { "name": "journal", "icon": "ref-cite-journal", "template": "Cite journal" } ]
After discussing with Trevor we decided the best way to implement this would be to have a parameter like 'label-position' which controls where the label appears.
I would recommend option 1.
Fixed by https://gerrit.wikimedia.org/r/#/c/134237/