Last modified: 2014-06-06 19:29:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67377, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65377 - OOjs UI: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup)
OOjs UI: Need a way to add a non-functional label to the top of a popupToolGr...
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-15 22:58 UTC by Ryan Kaldari
Modified: 2014-06-06 19:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-05-15 22:58:12 UTC
See design mock-up at https://trello.com/c/xCo6uLAZ/9-5-references-dropdown-from-toolbar-styling.

Right now, I can give a popupToolGroup a label by using the 'label' param in a toolbarGroup definition:
{
    'label': 'Cite',
    'type': 'list',
    'icon': 'reference',
    'title': OO.ui.deferMsg( 'visualeditor-toolbar-cite-label' ),
    'include': [ { 'group': 'cite' } ]
}

However, this puts the label above the popup (in the popupToolGroup-handle) rather than within the popup itself (as needed by the design linked to above).

I can imagine two different ways of providing this functionality:

1. Add a new type of param for toolbarGroups called something like 'inner-label'

2. Allow creating non-functional labels from the on-wiki group definition, for example:
[
    { "label": "cite" },
    { "name": "web", "icon": "ref-cite-web", "template": "Cite web" },
    { "name": "book", "icon": "ref-cite-book", "template": "Cite book" },
    { "name": "news", "icon": "ref-cite-news", "template": "Cite news" },
    { "name": "journal", "icon": "ref-cite-journal", "template": "Cite journal" }
]
Comment 1 Ryan Kaldari 2014-05-16 20:58:00 UTC
After discussing with Trevor we decided the best way to implement this would be to have a parameter like 'label-position' which controls where the label appears.
Comment 2 Trevor Parscal 2014-05-16 21:00:32 UTC
I would recommend option 1.
Comment 3 Ryan Kaldari 2014-06-06 19:08:06 UTC
Fixed by https://gerrit.wikimedia.org/r/#/c/134237/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links