Last modified: 2014-10-21 01:13:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67381, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65381 - Standardise on our grey colours
Standardise on our grey colours
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Hygiene (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks: 71627
  Show dependency treegraph
 
Reported: 2014-05-15 23:43 UTC by Jon
Modified: 2014-10-21 01:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-05-15 23:43:58 UTC
There are still various shades of gray that don't match with one of the predefined ones in variables.less

Let's review these and sort this out.
Comment 1 Jon 2014-10-02 18:54:00 UTC
Whoever works on this:
You will need to audit all our existing grays, replace them with variables and then replace the non-standard ones with the ones defined in core resources/src/mediawiki.less/mediawiki.ui/variables.less
Comment 2 Bahodir Mansurov 2014-10-02 23:01:52 UTC
Are you saying that if '#cacaca' is not defined in either variables.less file, then replace it with the closest color, which might be '#ccc'?
Comment 3 Gerrit Notification Bot 2014-10-02 23:25:09 UTC
Change 164488 had a related patch set uploaded by Bmansurov:
WIP: Standardize grey colors

https://gerrit.wikimedia.org/r/164488
Comment 4 Jon 2014-10-02 23:44:18 UTC
Not quite.. I'm suggesting that if we use #cacaca somewhere we should capture it in a meaningful variable name based on how it is being used and put it in our variables file

e.g. iconOverlayText: #cacaca

The next step would then be to chat to either Moiz, Kaity (who might want to defer to May) about changing those to use one of the standard colours in the color palette.

You'll need to okay any colour changes with one of them. #ccc may be a suitable replacement for #cacaca but I can't say! :)
Comment 5 Gerrit Notification Bot 2014-10-03 21:14:39 UTC
Change 164488 merged by jenkins-bot:
Standardize grey colors

https://gerrit.wikimedia.org/r/164488
Comment 6 Gerrit Notification Bot 2014-10-07 00:46:52 UTC
Change 165151 had a related patch set uploaded by Bmansurov:
Standardize grey colors

https://gerrit.wikimedia.org/r/165151
Comment 7 May 2014-10-07 02:06:49 UTC
(In reply to Bahodir Mansurov from comment #2)
> Are you saying that if '#cacaca' is not defined in either variables.less
> file, then replace it with the closest color, which might be '#ccc'?

Hey Bahodir, 

Reason Jon might say that #ccc might not be a suitable replacement for #cacaca is because for example, we have placeholder text standardized at #aaa. You can see a short list here https://trello.com/c/IRqbu8p4/15-color-swatches

Since the point of this bug is for standardization purposes, depending on what #cacaca is used for, there might already be a gray assigned to that usage. Let me know if I can help you in any way!
Comment 8 Bahodir Mansurov 2014-10-11 18:08:45 UTC
Thanks, May. I and Kaity have already converted the colors. ;)
Comment 9 Jon 2014-10-21 01:13:42 UTC
This is done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links