Last modified: 2014-05-18 06:29:29 UTC
Created attachment 15418 [details] Screenshot Cannot save any page on Betalabs with chrome , 500 (Internal Server Error) appears in the console
*** This bug has been marked as a duplicate of bug 65373 ***
This is a 500 from an API request: PHP fatal error in /srv/common-local/php-master/includes/api/ApiQueryAllPages.php line 34: Argument 1 passed to ApiQueryAllPages::__construct() must be an instance of ApiQuery, instance of ApiMain given, called in /srv/common-local/php-master/extensions/TimedMediaHandler/handlers/TextHandler/TextHandler.php on line 27
Caused by https://gerrit.wikimedia.org/r/#/c/120827/
Change 133772 had a related patch set uploaded by Anomie: ApiQueryBase subclasses take an ApiQuery, not an ApiMain https://gerrit.wikimedia.org/r/133772
Also, FYI, I found I couldn't reproduce this with "any page" as originally claimed. For testing on beta labs, it appears the page needs to embed a video (or other timed media, I'd guess) hosted on commons.wikimedia.beta.wmflabs.org; videos from commons.wikimedia.org won't do it, nor presumably would videos on the local beta wiki. If this makes it to production (it had better not!), any Commons video would do it. Also, VE use is not necessary. A normal preview of a page with an appropriate video works.
Change 133834 had a related patch set uploaded by Catrope: Fix API interaction code for MW core changes in 23632a4ecddd https://gerrit.wikimedia.org/r/133834
(In reply to Brad Jorsch from comment #5) > Also, FYI, I found I couldn't reproduce this with "any page" as originally > claimed. For testing on beta labs, it appears the page needs to embed a > video (or other timed media, I'd guess) hosted on > commons.wikimedia.beta.wmflabs.org; videos from commons.wikimedia.org won't > do it, nor presumably would videos on the local beta wiki. If this makes it > to production (it had better not!), any Commons video would do it. > > Also, VE use is not necessary. A normal preview of a page with an > appropriate video works. Yes. I discovered this independently, sorry for not reporting it here. It's a fatal in TMH when saving any page with a local video embedded in it. I put a patch in for TMH (which I live-tested on beta labs, with Bryan's help), could you review it? I ask because TMH is a very unloved area and if I don't actively poke people about it it'll never happen.
Change 133834 abandoned by Catrope: Fix API interaction code for MW core changes in 23632a4ecddd Reason: So he did Abandoning in favor of https://gerrit.wikimedia.org/r/#/c/133772 https://gerrit.wikimedia.org/r/133834
Change 133772 merged by jenkins-bot: ApiQueryBase subclasses take an ApiQuery, not an ApiMain https://gerrit.wikimedia.org/r/133772
(In reply to Roan Kattouw from comment #7) > I put a patch in for TMH (which I live-tested on beta labs, with Bryan's > help), could you review it? I ask because TMH is a very unloved area and if > I don't actively poke people about it it'll never happen. Never mind, you beat me by a lunch break. I merged your patch instead.
Verified the fix in Betalabs
Change 133852 had a related patch set uploaded by Jforrester: ApiQueryBase subclasses take an ApiQuery, not an ApiMain https://gerrit.wikimedia.org/r/133852
Change 133852 abandoned by Jforrester: ApiQueryBase subclasses take an ApiQuery, not an ApiMain Reason: My mistake, I somehow thought we'd found this in production. Never mind! https://gerrit.wikimedia.org/r/133852
