Last modified: 2014-09-13 18:12:53 UTC
Hey dude, great work on the extension! I've cloned the master build to my local wiki v1.22.5 and noticed a couple of issues. Warning: Missing argument 3 for UploadBase::detectScript(), called in /home/public/w/extensions/SocialProfile/UserGifts/SpecialGiftManagerLogo.php on line 702 and defined in /home/public/w/includes/upload/UploadBase.php on line 978 Could not copy file "/home/tmp/phpWFZbSw" to "". You appear to be missing a parameter $extension, in UploadBase::detectScript(). https://doc.wikimedia.org/mediawiki-core/master/php/html/classUploadBase.html#a02134a6e4226989e813138fdd734622c I fixed this locally, but the upload continues to fail when given a valid image. PHP can't move the file out of my temp directory as the destination filename is empty. The upload function is returning 0; I have not found the reason for this. Please let me know if you make any progress! :)
(In reply to Papaver Josepherum from comment #0) > I fixed this locally Hi! Thanks for investigating part of the problem(s)! If you feel like providing a patch, you are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/ Thanks again!
Change 160221 had a related patch set uploaded by Jack Phoenix: Missing $extension parameter for UploadBase::detectScript() https://gerrit.wikimedia.org/r/160221
Change 160221 merged by jenkins-bot: Missing $extension parameter for UploadBase::detectScript() https://gerrit.wikimedia.org/r/160221
(In reply to Papaver Josepherum from comment #0) > Hey dude, great work on the extension! I've cloned the master build to my > local wiki v1.22.5 and noticed a couple of issues. Thanks for the feedback and the bug report! I've added the missing $extension parameter to the two files which call UploadBase::detectScript(); it probably doesn't change a thing unless you were trying to upload .svg files, as UploadBase::detectScript() cares about the $extension parameter only then. > Could not copy file "/home/tmp/phpWFZbSw" to "". This is probably a file permissions issue, or 99% of similar cases have been just that. Double and/or triple-check the file permissions and see if you need to make any changes in file/folder ownership.
