Last modified: 2014-05-19 19:05:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67468, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65468 - Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section
Redirects to section are off in Firefox 29.0.1 if there are collapsed element...
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-19 05:58 UTC by Lupo
Modified: 2014-05-19 19:05 UTC (History)
4 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lupo 2014-05-19 05:58:46 UTC
From https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=609193453#Redirect_not_working_right

As of FF 29.0.1, redirects to section links are off if the page contains collapsed elements before the section link. Was fine in FF 28.

Looks like a race condition between the collapsing code and mediawiki.action.view.redirectToFragment.js

Example link: https://en.wikipedia.org/wiki/Wikipedia:NMOTORSPORT

Should go to https://en.wikipedia.org/wiki/Wikipedia:Notability_%28sports%29#Motorsports

Second link works, first link doesn't; through the redrect-to-section, you end up below the "Motorsports" section. Offset from the intended destination appears to match the height of the collapsed FAQ box at the page top.

The issue is not limited to en-WP, same behavior also observed at the Commons. Try https://commons.wikimedia.org/wiki/COM:NETCOPYRIGHT
This should go to https://commons.wikimedia.org/wiki/Commons:Copyright_rules_by_subject_matter#Internet_images
but actually ends up too far down, again the offset appears to correspond to the combined heights of the two collapsed elements above that section.
Comment 1 Andre Klapper 2014-05-19 09:16:29 UTC
I can confirm this for Firefox 29; comments in Village Pump say that there is no issue in Firefox 28.
Comment 2 Andre Klapper 2014-05-19 09:17:10 UTC
...and clicking the browser's address bar and pressing Enter fixes the problem.
Comment 3 Lupo 2014-05-19 09:58:47 UTC
Another thought: mediawiki.action.view.redirectToFragment.js does

  if ( window.location.hash === fragment ) {
    window.location.hash = fragment;
  }

i.e., it sets it to the value it already has. Maybe the Firefox people decided not to do anything if location.hash is set, but the value doesn't change?
Comment 4 Andre Klapper 2014-05-19 11:14:55 UTC
Only stuff vaguely related in upstream I could find is https://bugzilla.mozilla.org/show_bug.cgi?id=483304 and https://bugzilla.mozilla.org/show_bug.cgi?id=668213

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links