Last modified: 2014-06-02 08:17:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67477, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65477 - User::pingLimiter should have per action profiling


Summary:	User::pingLimiter should have per action profiling

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	65478
	Show dependency tree / graph

Reported:	2014-05-19 10:38 UTC by Antoine "hashar" Musso (WMF)
Modified:	2014-06-02 08:17 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-05-19 10:38:39 UTC

User::pingLimiter() let us limit some actions (default: 'edit'). The wfProfileIn() entry point does not vary by action.  The related statsd metric generated on Wikimedia cluster is MediaWiki.User.pingLimiter

We had an incident beginning of May 2014 which had some thumb rendering action being limited.  Having a graph dedicated to that action would have help spot the action being throttled.


We can probably just:

 wfProfileIn( __METHOD__ );
 wfProfileIn( __METHOD__ . '-' . $action );
 

Context:

https://wikitech.wikimedia.org/wiki/Incident_documentation/20140503-Thumbnails

Comment 1 Gerrit Notification Bot 2014-05-19 10:46:41 UTC

Change 134067 had a related patch set uploaded by Hashar:
User::pingLimiter() profiles per action as well

https://gerrit.wikimedia.org/r/134067

Comment 2 Gerrit Notification Bot 2014-05-20 17:41:21 UTC

Change 134067 merged by jenkins-bot:
User::pingLimiter() profiles per action as well

https://gerrit.wikimedia.org/r/134067

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links