Last modified: 2014-05-19 21:00:31 UTC
The 'anonymouseditoracquisitionpostedit' guided tour (hosted in GettingStarted extension) has an unordered list in the content. Unlike other tours hosted in the GettingStarted extension, the contents of this list are not displaying the translated content in French, German, and Italian Wikipedias. This is despite the fact that the translation is complete according to translatewiki and localization update has had days to run. Since tours without a custom unordered list in them are being displayed correctly with translated content, we suspect that this is related to the contents of anonymouseditoracquisitionpostedit.
Created attachment 15439 [details] French Wikipedia
Created attachment 15440 [details] Italian Wikipedia
Created attachment 15441 [details] German Wikipedia
(In reply to Steven Walling from comment #0) > The 'anonymouseditoracquisitionpostedit' guided tour (hosted in > GettingStarted extension) has an unordered list in the content. > > Unlike other tours hosted in the GettingStarted extension, the contents of > this list are not displaying the translated content in French, German, and > Italian Wikipedias. This is despite the fact that the translation is > complete according to translatewiki and localization update has had days to > run. > > Since tours without a custom unordered list in them are being displayed > correctly with translated content, we suspect that this is related to the > contents of anonymouseditoracquisitionpostedit. For reference this should be Guidedtour-tour-anonymouseditoracquisitionpostedit-description message.
guidedtour-tour-anonymouseditoracquisitionpostedit-description is translated to Italian on master, 1.24wmf4, and 1.24wmf5: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/master/i18n%2Fit.json https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/refs%2Fheads%2Fwmf%2F1.24wmf4/i18n%2Fit.json https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/refs%2Fheads%2Fwmf%2F1.24wmf5/i18n%2Fit.json But in the actual server response, it is not: https://bits.wikimedia.org/it.wikipedia.org/load.php?debug=true&lang=it&modules=ext.gettingstarted.anonymousEditorAcquisition&skin=vector&version=20140519T175221Z&*
As discussed on IRC, this may (or may not) be related to the fact that I added linebreaks to this message in https://gerrit.wikimedia.org/r/#/c/133049/ .
This is not the underlying cause, but it's confusing, so it should be fixed before this is marked FIXED: The guidedtour-tour-anonymouseditoracquisitionpostedit-* messages should be in the module that actually uses them, ext.guidedTour.tour.anonymouseditoracquisitionpostedit
^ Patch which moves messages https://gerrit.wikimedia.org/r/#/c/134165/
de - http://bits.wikimedia.org/de.wikipedia.org/load.php?debug=false&lang=de&modules=ext.gettingstarted.anonymousEditorAcquisition&skin=vector&version=20140519T175221Z&* en - http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.gettingstarted.anonymousEditorAcquisition&skin=vector&version=20140519T175221Z&* fr - http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=false&lang=fr&modules=ext.gettingstarted.anonymousEditorAcquisition&skin=vector&version=20140519T175221Z&* it - http://bits.wikimedia.org/it.wikipedia.org/load.php?debug=false&lang=it&modules=ext.gettingstarted.anonymousEditorAcquisition&skin=vector&version=20140519T175221Z&* are all wrong. However: echo wfMessage( 'guidedtour-tour-anonymouseditoracquisitionpostedit-description' )->text(); yields the right value with an eval.php shell on all four wikis: So it's apparently a caching issue, possibly connected to https://www.mediawiki.org/wiki/Manual:Msg_resource_table / https://www.mediawiki.org/wiki/Manual:Msg_resource_links_table
Change 134165 had a related patch set uploaded by Mattflaschen: Move post edit messages into the post edit RL module https://gerrit.wikimedia.org/r/134165
Change 134165 merged by jenkins-bot: Move post edit messages into the post edit RL module https://gerrit.wikimedia.org/r/134165
Change 134226 had a related patch set uploaded by Mattflaschen: Move post edit messages into the post edit RL module https://gerrit.wikimedia.org/r/134226
Change 134226 merged by jenkins-bot: Move post edit messages into the post edit RL module https://gerrit.wikimedia.org/r/134226
Change 134227 had a related patch set uploaded by Mattflaschen: Move post edit messages into the post edit RL module https://gerrit.wikimedia.org/r/134227
Change 134227 merged by jenkins-bot: Move post edit messages into the post edit RL module https://gerrit.wikimedia.org/r/134227
(In reply to Gerrit Notification Bot from comment #15) > Change 134227 merged by jenkins-bot: > Move post edit messages into the post edit RL module > > https://gerrit.wikimedia.org/r/134227 Merging and deploying this invalidated the cache and everything looks fine now on French and German.
