Last modified: 2014-10-24 18:15:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67527, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65527 - pencil icon for "Edit links" should use wikifont
pencil icon for "Edit links" should use wikifont
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=design p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-20 11:24 UTC by Amir E. Aharoni
Modified: 2014-10-24 18:15 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
a screenshot with the problem (ignore the star) (18.28 KB, image/png)
2014-05-20 11:24 UTC, Amir E. Aharoni
Details

Description Amir E. Aharoni 2014-05-20 11:24:37 UTC
Created attachment 15445 [details]
a screenshot with the problem (ignore the star)

The pencil icon in "Edit links" is a PNG and it becomes pixelated when zooming. It should be vector. See the screenshot and compare it to the ULS gear icon, which is not pixelated.
Comment 1 Lydia Pintscher 2014-05-21 12:29:18 UTC
Do you guys have an appropriate icon? Then hoo can easily swap it I think.
Comment 2 Jared Zimmerman (WMF) 2014-05-21 19:29:27 UTC
Best option is to use the pencil icon from wikifont

second pest option is to use the svg version for edit currently being used on mobile articles. 

adding Shahyar as a point of contact for wikifont
Comment 4 Jared Zimmerman (WMF) 2014-05-21 19:41:02 UTC
Yes you can see the icon in use here https://en.m.wikipedia.org/wiki/Kenneth_R._Shadrick

We can adjust the color programmatically to "Gray 7"

https://trello.com/c/IRqbu8p4/15-color-swatches
Comment 5 Marius Hoch 2014-10-17 16:08:48 UTC
I played with this for a bit and the icon doesn't look very nice (it's not identifiable as a pencil) downscaled to the size we need for the sidebar.
Comment 6 Jared Zimmerman (WMF) 2014-10-20 18:48:39 UTC
Just looked at the icon in that context at 10px and 12px, both seem fine. 

your screenshot shows the old raster icon rather than the new svg. 

I'm not sure an icon is even needed in this context, what do you think?
Comment 7 Marius Hoch 2014-10-24 15:41:02 UTC
(In reply to Jared Zimmerman (WMF) from comment #6)
> Just looked at the icon in that context at 10px and 12px, both seem fine. 
> 
> your screenshot shows the old raster icon rather than the new svg. 
I'm not sure that was worded clear enough: I tested using https://www.mediawiki.org/wiki/Design/Wikifont#mediaviewer/File:Edit_icon.svg as a replacement for our icon (but I recolored it to be in a gray similar to our current icon) first.

> I'm not sure an icon is even needed in this context, what do you think?
That's a good question, actually... after removing the icon and the left padding from the "Add links" link it actually looks quite ok to me. Maybe not as nice as the current version, but still ok.
Comment 8 Jared Zimmerman (WMF) 2014-10-24 18:15:09 UTC
If you don't like the look of the icon at that size, I'd recommend we remove the icon and adjust the padding accordingly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links