Last modified: 2014-07-22 22:55:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67536, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65536 - Use original wikitext when selectively serializing unmodified text content
Use original wikitext when selectively serializing unmodified text content
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: ssastry
:
Depends on: 56601
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-20 16:05 UTC by Gabriel Wicke
Modified: 2014-07-22 22:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2014-05-20 16:05:14 UTC 
As discussed in bug 64901, a major source of dirty diffs when using selser is nowiki insertion in unwrapped top-level text content. We can avoid this by leveraging the dsr information of adjacent elements to substring the original wikitext for unmodified text nodes.

This requires annotating text node modifications while DOM diffing. One option is to wrap modified text nodes in a span. Another is to add a marker on the preceding element when the following text node was modified.
Comment 1 Gabriel Wicke 2014-05-20 16:06:39 UTC 
Setting to high priority as this looks like the biggest source of non-local dirty diffs when using selser currently.
Comment 2 Helder 2014-05-26 12:47:51 UTC 
2^16 bugs :-)
Comment 3 Gabriel Wicke 2014-05-27 20:45:29 UTC 
(In reply to Helder from comment #2)
> 2^16 bugs :-)

We're now firmly in 32 bit land ;)
Comment 4 ssastry 2014-07-22 22:55:38 UTC 
These fixes have been deployed for a while now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links