Last modified: 2014-05-20 19:35:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67542, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65542 - [Trebuchet] failed to update scap version on minions
[Trebuchet] failed to update scap version on minions
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Immediate blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-20 18:39 UTC by Greg Grossmeier
Modified: 2014-05-20 19:35 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Greg Grossmeier 2014-05-20 18:39:19 UTC
14:23 < bd808|dep> mutante: Trying to `get deploy sync` scap from tin with 
                   result of "0/230 minions completed fetch"
Comment 1 Greg Grossmeier 2014-05-20 18:40:09 UTC
Setting it to Immediate importance.

Opsen: please triage/assign to whoever will debug/diagnose.
Comment 2 Greg Grossmeier 2014-05-20 18:41:44 UTC
14:39 <     bd808> mutante: I would say that May  7 22:49 was the last time 
                   `git deploy sync` was used on the scap repo
Comment 3 Bryan Davis 2014-05-20 18:42:43 UTC
tin:/srv/deployment/scap/scap  (git master)
bd808$ git deploy sync
Repo: scap/scap
Tag: scap/scap-sync-20140520-181227

0/230 minions completed fetch
Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): r
Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): r
Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): d
Repo: scap/scap
Tag: scap/scap-sync-20140520-181227

0/230 minions completed fetch

Details:

mw1068.eqiad.wmnet:
        fetch status: 10 [started: 0 mins ago, last-return: 0 mins ago]
[..snip..]
Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): r
Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): c
Repo: scap/scap
Tag: scap/scap-sync-20140520-181227

0/230 minions completed fetch
Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): n
Not continuing to checkout phase. A deployment is still underway, please finish,
 sync, or abort.
tin:/srv/deployment/scap/scap  (git master)
bd808$ git deploy abort
Deployment aborted.
Comment 4 Bryan Davis 2014-05-20 18:53:36 UTC
Last deployed tag seems to be "scap/scap-sync-20140507-224859"
Comment 5 Bryan Davis 2014-05-20 18:58:05 UTC
$ ls -ld /srv/deployment/scap/scap
drwxrws--- 6 trebuchet wikidev 4096 May  1 20:07 /srv/deployment/scap/scap/


Directory permissions are borked. The apache user needs to be able to read the directory in order to serve it to the minions. Should be "drwxrwsr-x".
Comment 6 Greg Grossmeier 2014-05-20 19:02:04 UTC
14:59 < Ryan_Lane> chmod o+rx /srv/deployment/scap/scap/
14:59 <   mutante> already done

(after test of git-deploy of scap)
15:01 <     bd808> greg-g: \o/
Comment 7 Bryan Davis 2014-05-20 19:35:38 UTC
Directory permissions were probably broken initially because in the current setup tin is acting as both the deploy server and a minion for the scap deploy. When the minion gets the fetch/checkout commands from salt it runs as root. I sort of wondered if this would cause problems and I think now I have my answer.

We can either try to rearrange the way that classes are defined in operations/puppet.git to eliminate this problem or figure out how to make trebuchet aware of the edge case and avoid updating the deployment server if it is also in the minions list.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links