Last modified: 2014-05-23 19:38:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67560, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65560 - A very long title causes a false "network error" in search
A very long title causes a false "network error" in search
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
Android (alpha)
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-20 22:34 UTC by Liangent
Modified: 2014-05-23 19:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2014-05-20 22:34:24 UTC

    
Comment 1 Bernd Sitzmann 2014-05-21 21:18:32 UTC
I have a hard time reproducing this. Would you provide an example? I've created https://test.wikipedia.org/wiki/1234567890123456789012345678901234567890123456789012345678901234567890, which has a title of 70 characters but that seems to be working. How long is the title you've tried? Thanks!
Comment 2 Dan Garry 2014-05-21 21:28:27 UTC
(In reply to Bernd Sitzmann from comment #1)
> I have a hard time reproducing this. Would you provide an example? I've
> created
> https://test.wikipedia.org/wiki/
> 1234567890123456789012345678901234567890123456789012345678901234567890,
> which has a title of 70 characters but that seems to be working. How long is
> the title you've tried? Thanks!

There are even longer ones already live on the site, such as [[Another Demonstration of the Cliff-Guibert Fire Hose Reel, Showing a Young Girl Coming from an Office, Detaching Hose, Running with It 60 Feet, and Playing a Stream, All Inside of 30 Seconds]] which is 190 characters long. That page works in the app for me, so I'm not sure what's causing this crash.
Comment 3 Liangent 2014-05-21 21:36:35 UTC
I created the long title by typing some characters then repeating "select all - copy - paste - paste - paste" several times. I guess it is some "network" / http error: 414 Request-URI Too Large.

To resolve this, very long, if not all, queries should be POSTed.
Comment 4 Liangent 2014-05-21 21:38:16 UTC
This also causes "Could not reach the network :(" when I try to Go directly.
Comment 5 Gerrit Notification Bot 2014-05-21 22:49:17 UTC
Change 134749 had a related patch set uploaded by BearND:
Restrict length of search input to 255

https://gerrit.wikimedia.org/r/134749
Comment 6 Bernd Sitzmann 2014-05-21 22:52:49 UTC
(In reply to Dan Garry from comment #2)
> (In reply to Bernd Sitzmann from comment #1)
> > I have a hard time reproducing this. Would you provide an example? I've
> > created
> > https://test.wikipedia.org/wiki/
> > 1234567890123456789012345678901234567890123456789012345678901234567890,
> > which has a title of 70 characters but that seems to be working. How long is
> > the title you've tried? Thanks!
> 
> There are even longer ones already live on the site, such as [[Another
> Demonstration of the Cliff-Guibert Fire Hose Reel, Showing a Young Girl
> Coming from an Office, Detaching Hose, Running with It 60 Feet, and Playing
> a Stream, All Inside of 30 Seconds]] which is 190 characters long. That page
> works in the app for me, so I'm not sure what's causing this crash.

Dan, the problem doesn't occur when one just accepts the search suggestion. One has to type a ton of characters into the search field. Anyways, my patch should restrict prevent this now, since I'm restricting the length of the field to 255 characters, the same amount the server allows.
Comment 7 Bernd Sitzmann 2014-05-21 22:53:27 UTC
See also discussion with liangent on IRC today
Comment 8 Bernd Sitzmann 2014-05-21 23:10:47 UTC
got something like {"info":"Prefix search request was longer longer than the maximum allowed length. (2304 > 255)","code":"request_too_long"} from opensearch api before.
Comment 9 Gerrit Notification Bot 2014-05-21 23:29:07 UTC
Change 134749 merged by jenkins-bot:
Restrict length of search input to 255

https://gerrit.wikimedia.org/r/134749

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links