Last modified: 2014-07-05 21:48:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67567, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65567 - Add hook to prohibit HTTP -> HTTPS redirect
Add hook to prohibit HTTP -> HTTPS redirect
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-20 23:55 UTC by Yuri Astrakhan
Modified: 2014-07-05 21:48 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuri Astrakhan 2014-05-20 23:55:46 UTC
Whenever user has forceHTTPS cookie, any request that comes in via HTTP is automatically redirected to HTTPS. This behaviour is ok for most of the usecases, but it causes countless grievances in the zero-land for the following scenario:

User logs in (or obtains forceHTTPS cookie via some other means) while browsing *.wikipedia.org on WiFi or mobile network. At some point, they discover that their carrier offers wikipedia for free via *.zero.wikipedia.org. They try to navigate there, only to discover that they get an error screen due to using HTTPS (which is not supported by zero most of the time). They report it to the carrier, carrier, complains to us, and we have to explain to them that the only way for the user to use us ever since they got tainted by the "forceHTTPS" is to clear their browser's cookie storage.

In order to prevent the unnesesary grievance by many users (and we have heard a lot of this scenario), Zero extension needs to intercept http->https redirect. This redirect happens before most of the code, hence a new hook is needed, as implemented in Change-Id: If04c83066c5d4.

The redirect will be canceled only for the case of valid traffic from Zero partner , exclusivelly to *.zero. subdomain.

Please note that we are not breaking existing functionality here since zero hasn't had a valid SSL certificate until a week ago, and regardless, we do not currently support authentication or editing via zero subdomain.
Comment 1 Yuri Astrakhan 2014-05-21 17:48:48 UTC
Two pending patches:
Core: If04c83066c5d4
Zero: Ia8b620282bb01
Comment 2 Andre Klapper 2014-07-05 21:30:54 UTC
(In reply to Yuri Astrakhan from comment #1)
> Two pending patches:
> Core: If04c83066c5d4
> Zero: Ia8b620282bb01

Yuri: Both merged. What's left here?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links