Last modified: 2014-06-10 23:19:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67616, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65616 - VisualEditor: [Regression wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null
VisualEditor: [Regression wmf6] Hovering over any right aligned and frameless...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-05-29
Assigned To: Roan Kattouw
:
Depends on:
Blocks: 65829
  Show dependency treegraph
 
Reported: 2014-05-21 23:16 UTC by Rummana Yasmeen
Modified: 2014-06-10 23:19 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (144.29 KB, image/png)
2014-05-22 05:56 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-05-21 23:16:02 UTC
Steps to reproduce:

1.Open a oage with VE
2.Insert an image
3.Make it right aligned and framless
4.Hover over it

Observed Result:
It throws the following error:
Uncaught TypeError: Cannot read property 'getSurface' of null
Comment 1 Rummana Yasmeen 2014-05-22 05:56:23 UTC
It also happens for the following case:

1. Change alignment of any image
2. Delete the image
3. Observe that, the phantom of the image is still there after deleting the image
4.Now hover over the phantom

Observed Result:
As soon as you delete the image the error: Cannot read property 'getSurface' of null appears, also everytime you hover over the phantom , you will get this same error.

See the screenshot attached
Comment 2 Rummana Yasmeen 2014-05-22 05:56:49 UTC
Created attachment 15455 [details]
Screenshot
Comment 3 Gerrit Notification Bot 2014-05-22 14:55:52 UTC
Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363
Comment 4 James Forrester 2014-05-22 21:58:25 UTC
Fixed and backport going out in SWAT.
Comment 5 Gerrit Notification Bot 2014-05-22 22:27:03 UTC
Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363
Comment 6 James Forrester 2014-05-22 23:19:32 UTC
Still fixed.
Comment 7 Rummana Yasmeen 2014-05-23 01:24:47 UTC
Verified the fix in Betalabs and test 2
Comment 8 Rummana Yasmeen 2014-06-06 21:46:04 UTC
Verified the fix in production.
Comment 9 Gerrit Notification Bot 2014-06-10 23:19:11 UTC
Change 134363 merged by jenkins-bot:
[BREAKING CHANGE] Merge ProtectedNode into FocusableNode

https://gerrit.wikimedia.org/r/134363

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links