Last modified: 2014-06-13 19:37:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67619, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65619 - Make CentralAuth an optional dependency
Make CentralAuth an optional dependency
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-22 02:50 UTC by Matthew Flaschen
Modified: 2014-06-13 19:37 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-05-22 02:50:44 UTC
Currently, CentralAuth is documented as a hard dependency.  RingtailedFox expressed interest in installing GettingStarted, but CA was a potential issue.  Other people have may the same concern, so it would be good to explicitly make it optional.

Ideally, we should:

* Either auto-detect CentralAuth (may need to use ExtensionFunctions or something so include order isn't an issue) or just have a variable, and register the appropriate hooks.
# Have the same behavior (adding ?gettingStartedReturn=true and showing modal) either way.

And then we can document it as not required.
Comment 1 Matthew Flaschen 2014-05-22 02:50:58 UTC
Sorry, meant to file as GettingStarted.
Comment 2 Matthew Flaschen 2014-06-05 23:17:43 UTC
Related patches:

Supporting hook in core: https://gerrit.wikimedia.org/r/#/c/135886/

GettingStarted: https://gerrit.wikimedia.org/r/#/c/135888/
Comment 3 Gerrit Notification Bot 2014-06-05 23:31:56 UTC
Change 135886 had a related patch set uploaded by Mattflaschen:
Create PostLoginRedirect Hook for changing the redirect behavior

https://gerrit.wikimedia.org/r/135886
Comment 4 Gerrit Notification Bot 2014-06-10 22:42:17 UTC
Change 135888 had a related patch set uploaded by Robmoen:
Optionally depend on CentralAuth's redirect hook

https://gerrit.wikimedia.org/r/135888
Comment 5 Gerrit Notification Bot 2014-06-12 14:24:53 UTC
Change 135886 merged by jenkins-bot:
Create PostLoginRedirect Hook for changing the redirect behavior

https://gerrit.wikimedia.org/r/135886
Comment 6 Gerrit Notification Bot 2014-06-13 17:05:47 UTC
Change 135888 merged by Phuedx:
Optionally depend on CentralAuth's redirect hook

https://gerrit.wikimedia.org/r/135888

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links