Last modified: 2014-10-09 21:32:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67622, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65622 - Hygiene: common.less and main.less are dumping grounds and need tidying up
Hygiene: common.less and main.less are dumping grounds and need tidying up
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Hygiene (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-22 08:29 UTC by Jon
Modified: 2014-10-09 21:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-05-22 08:29:41 UTC 
Let's componentise these.
main.less previously typography.less are too ambigious and it's not clear when one should go in the other.

For instance link colors in common.less are also content and primarily used in content and plainlinks and there are some line-heights for paragraph and lists

These should instead be split up into features
e.g. thumbnails, tables, links, gallerys etc...
Comment 1 Gerrit Notification Bot 2014-10-08 02:06:18 UTC 
Change 165421 had a related patch set uploaded by Robmoen:
Split out content less into features

https://gerrit.wikimedia.org/r/165421
Comment 2 Gerrit Notification Bot 2014-10-09 19:35:41 UTC 
Change 165421 abandoned by Robmoen:
Split out content less into features

Reason:
Abandon in favor of smaller commits

https://gerrit.wikimedia.org/r/165421
Comment 3 Jon 2014-10-09 21:32:18 UTC 
much nicer
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links