Last modified: 2014-06-09 19:11:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67645, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65645 - VisualEditor: Span tags for Language tool only mark part of the page
VisualEditor: Span tags for Language tool only mark part of the page
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Editing team bugs – take if you're interested!
https://office.wikimedia.org/w/index....
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-22 17:53 UTC by WhatamIdoing
Modified: 2014-06-09 19:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-05-22 17:53:27 UTC
Intention:
Mark almost an entire page with language (en) and direction (LTR).

Steps to Reproduce:
1.  Open the page and select almost all of the content.
 
2.  Insert > Language

3.  Set the language to English and the direction to LTR.

Actual Results:  
Only a small fraction of the page was marked with span tags.  See https://office.wikimedia.org/w/index.php?diff=112247&oldid=112246

Expected Results:  
I wanted this:

<span lang="en" dir="ltr">
Div box 
Image
Text
Image
Some text
End of div box
Lots and lots and lots of text
</span>

I got this:

Div box 
Image
<span lang="en" dir="ltr">Text</span>
Image
<span lang="en" dir="ltr">Text</span>Some te</span>xt
End of div box
Lots and lots and lots of text


Reproducible: Always

This was exactly repeatable on this page:  the last span tag always ended in the middle of the same word.
Comment 1 James Forrester 2014-06-09 15:46:08 UTC
The language tool only covers text, not block content, so that's expected.

The not-getting-to-the-end-of-the-selection thing sounds like an odd data model bug.
Comment 2 WhatamIdoing 2014-06-09 19:11:03 UTC
When I've selected the whole page, I'd rather have the whole page marked with a single pair of tags, even if defining the block content as having a "language" is meaningless.
Comment 3 James Forrester 2014-06-09 19:11:59 UTC
(In reply to WhatamIdoing from comment #2)
> When I've selected the whole page, I'd rather have the whole page marked
> with a single pair of tags, even if defining the block content as having a
> "language" is meaningless.

Tough. That's not how HTML works. :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links