Last modified: 2014-11-03 16:25:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67653, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65653 - VisualEditor: avoid causing "Translation unit markers in unexpected position" edit abort


Summary:	VisualEditor: avoid causing "Translation unit markers in unexpected position"...

Status:	ASSIGNED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor
Target Milestone:	---
Assigned To:	Editing team bugs – take if you're interested!

URL:
Whiteboard:
Keywords:

Depends on:	56451
Blocks:
	Show dependency tree / graph

Reported:	2014-05-22 19:24 UTC by James Forrester
Modified:	2014-11-03 16:25 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2014-05-22 19:24:46 UTC

"Translation unit markers in unexpected position." can just go die in Hell. Gah.

Comment 1 Nemo 2014-11-01 18:22:27 UTC

(In reply to James Forrester from comment #0)
> "Translation unit markers in unexpected position." can just go die in Hell.
> Gah.

Is this bug related to other bugs?

Comment 2 James Forrester 2014-11-03 16:05:10 UTC

(In reply to Nemo from comment #1)
> (In reply to James Forrester from comment #0)
> > "Translation unit markers in unexpected position." can just go die in Hell.
> > Gah.
> 
> Is this bug related to other bugs?

I don't know. You're the Translate extension expert. :-)

Comment 3 Nemo 2014-11-03 16:13:06 UTC

(In reply to James Forrester from comment #2)
> I don't know. You're the Translate extension expert. :-)

Ok. That error probably just means that some newline was inserted in the wrong place before or after <!--T:1--> and similar, IIRC.

So if you don't have a specific intention here I guess this is one bug of the series "make VisualEditor not touch Translate stuff which otherwise breaks" (bug 56451, bug 71730), and is probably blocked on bug 48891 as its friends.

Comment 4 James Forrester 2014-11-03 16:16:36 UTC

(In reply to Nemo from comment #3)
> (In reply to James Forrester from comment #2)
> > I don't know. You're the Translate extension expert. :-)
> 
> Ok. That error probably just means that some newline was inserted in the
> wrong place before or after <!--T:1--> and similar, IIRC.
> 
> So if you don't have a specific intention here I guess this is one bug of
> the series "make VisualEditor not touch Translate stuff which otherwise
> breaks" (bug 56451, bug 71730), and is probably blocked on bug 48891 as its
> friends.

No, this is not a parser bug.

It's just a "VE should react to stupidly vague error responses by killing stupid comments in stupid places used by a stupid extension to do critical functions that should be done better" bug. :-)

Comment 5 Nemo 2014-11-03 16:22:07 UTC

I guess it can also be put that way. :) Does this new summary reflect the aim?

Comment 6 James Forrester 2014-11-03 16:25:43 UTC

(In reply to Nemo from comment #5)
> I guess it can also be put that way. :) Does this new summary reflect the
> aim?

Not really. Putting a hack into VisualEditor to cope with another extension's model is not good. Either way, I don't care enough. :-)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links