Last modified: 2014-09-19 21:09:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67654, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65654 - parser tests drops anything in $wgSharedTables
parser tests drops anything in $wgSharedTables
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.24rc
All All
: High normal (vote)
: ---
Assigned To: Bawolff (Brian Wolff)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-22 20:34 UTC by Bawolff (Brian Wolff)
Modified: 2014-09-19 21:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
legoktm.wikipedia: Backport_to_Stable-


Attachments

Description Bawolff (Brian Wolff) 2014-05-22 20:34:35 UTC
Running parser tests:

bawolff@Bawolff-L:/var/www/w/git/tests$ php parserTests.php --regex ifexist
This is MediaWiki version 1.24alpha (81be7ed).

A database error has occurred. Did you forget to run maintenance/update.php after upgrading?  See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script
Query: CREATE TEMPORARY  TABLE `wikidb.user` (LIKE `wikidb.user`)
Function: DatabaseMysqlBase::duplicateTableStructure
Error: 1066 Not unique table/alias: 'wikidb.user' (localhost)


After which I noticed that I no longer had a User table, since the unit tests thought it was the thing it was duplicating to, and dropped the original.


Note: I had my local wiki set up to use LBFactoryMulti. I don't know if that's related.
Comment 1 Gerrit Notification Bot 2014-05-22 20:45:15 UTC
Change 134930 had a related patch set uploaded by Brian Wolff:
Double check its safe before dropping new table during db cloning

https://gerrit.wikimedia.org/r/134930
Comment 2 Bawolff (Brian Wolff) 2014-05-22 21:29:05 UTC
Turns out it was because I had $wgSharedTables = array( 'user', 'ipblocks' ); from a previous bug I was testing.
Comment 3 Gerrit Notification Bot 2014-05-22 21:37:56 UTC
Change 134947 had a related patch set uploaded by Brian Wolff:
Make CloneDatabase error out on shared tables.

https://gerrit.wikimedia.org/r/134947
Comment 4 Gerrit Notification Bot 2014-06-19 09:40:44 UTC
Change 134947 merged by jenkins-bot:
Make CloneDatabase error out on shared tables.

https://gerrit.wikimedia.org/r/134947
Comment 5 Antoine "hashar" Musso (WMF) 2014-06-25 11:03:13 UTC
Might be worth back porting the patch to REL1_23
Comment 6 Gerrit Notification Bot 2014-06-25 11:05:35 UTC
Change 134930 merged by jenkins-bot:
Double check its safe before dropping new table during db cloning

https://gerrit.wikimedia.org/r/134930
Comment 7 Gerrit Notification Bot 2014-06-25 18:00:55 UTC
Change 142018 had a related patch set uploaded by MarkAHershberger:
Double check its safe before dropping new table during db cloning

https://gerrit.wikimedia.org/r/142018
Comment 8 Mark A. Hershberger 2014-06-25 18:02:26 UTC
Not sure if this is needed in REL1_23 since tarballs ship without tests, but we can include it if needed.
Comment 9 Tomasz W. Kozlowski 2014-06-27 19:45:40 UTC
Merged in core master and cherry-picked to REL1_23, so marking as RESOLVED FIXED. 

Leaving Brian as assignee so he can take the glory.
Comment 10 Gerrit Notification Bot 2014-09-19 21:09:11 UTC
Change 142018 abandoned by Legoktm:
Double check its safe before dropping new table during db cloning

Reason:
Apparently not.

https://gerrit.wikimedia.org/r/142018

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links