Last modified: 2014-05-26 06:30:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67664, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65664 - Tipsy (jquery.tipsy) should disappear on click
Tipsy (jquery.tipsy) should disappear on click
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-23 06:19 UTC by Nemo
Modified: 2014-05-26 06:30 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2014-05-23 06:19:11 UTC
As a user, when a Tipsy thingy covers something I want to click (like the "edit") button, I want it to disappear immediately by clicking it, without having to wait an undeterminate amount of time.
Comment 1 Nemo 2014-05-23 06:29:23 UTC
Example on attachment 15460 [details].
Comment 2 Florian 2014-05-23 07:49:28 UTC
UniversalLanguageSelector has already a trigger to hide tipsy after click on it:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector/e3a480205c7cf5ce93f8bcb1c20868e2e54801cb/resources%2Fjs%2Fext.uls.interface.js
lin 301.

The sam tipsy function "hide" as used in timer, so no bug in tipsy itself (it hides after timer expired) i think.
Comment 3 Nemo 2014-05-23 07:52:45 UTC
(In reply to Florian from comment #2)
> The sam tipsy function "hide" as used in timer

But that's not what I asked. I don't care about timers. Any reason not to satisfy the request in core?
Comment 4 Florian 2014-05-23 08:12:52 UTC
(In reply to Nemo from comment #3)
> (In reply to Florian from comment #2)
> I don't care about timers. Any reason not to

I understand you ;)

> satisfy the request in core?

tipsy has the function hide, which can be triggered in Extension (like in code of UniversalLanguageSelector). Now the problem is, in my opinion, that the hideTipsy function isn't triggered when clicked on the tipsy :)

That's my view on the problem.
Comment 5 Gerrit Notification Bot 2014-05-23 10:15:38 UTC
Change 135010 had a related patch set uploaded by Florianschmidtwelzow:
Fix close tipsy on click

https://gerrit.wikimedia.org/r/135010
Comment 6 Florian 2014-05-23 10:17:53 UTC
It's an error in uls, not in core. The hide was on click listener of uls-trigger, not on the tipsy itself. So, no need to change anything in core :) (not every tipsy has to close on click :))
Comment 7 Gerrit Notification Bot 2014-05-26 06:15:19 UTC
Change 135010 merged by jenkins-bot:
Close the tipsy tooltip when clicked on it

https://gerrit.wikimedia.org/r/135010

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links