Last modified: 2014-06-26 00:33:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67707, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65707 - VisualEditor: Insert a <br /> when the user creates a new line from an existing blank link
VisualEditor: Insert a <br /> when the user creates a new line from an existi...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-23 23:03 UTC by Jared Zimmerman (WMF)
Modified: 2014-06-26 00:33 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
pre-save (100.83 KB, image/png)
2014-05-28 18:37 UTC, Jared Zimmerman (WMF)
Details
post-save (92.15 KB, image/png)
2014-05-28 18:38 UTC, Jared Zimmerman (WMF)
Details

Description Jared Zimmerman (WMF) 2014-05-23 23:03:11 UTC

    
Comment 1 Andre Klapper 2014-05-26 11:07:36 UTC
Please provide steps to reproduce - no idea at which stage/keyboard focus I press some key on my keyboard, and which browsers this was tested with

Please see https://www.mediawiki.org/wiki/How_to_report_a_bug
Comment 2 Jared Zimmerman (WMF) 2014-05-28 18:36:55 UTC
go to https://en.wikipedia.org/wiki/User:Jaredzimmerman_%28WMF%29/VEtest

1. place cursor after "line 1"
2. press enter/return on keyboard twice
3. save page

expected : there will be two blank lines after "line 1"
actual: there are no blank lines after "line 1"

see attached images for pre and post save appearance.
Comment 3 Jared Zimmerman (WMF) 2014-05-28 18:37:45 UTC
Created attachment 15502 [details]
pre-save
Comment 4 Jared Zimmerman (WMF) 2014-05-28 18:38:17 UTC
Created attachment 15503 [details]
post-save
Comment 5 James Forrester 2014-06-06 00:38:46 UTC
Unfortunately MediaWiki has no representation of a blank paragraph, so they get destroyed when you save.

We could theoretically not let you insert a second new line (so "enter" in a blank paragraph does nothing), and though this is an extant UX in the wild – LyX does this because LaTeX has the same limitation – I think it's pretty crummy, and probably worse than the current behaviour.

What would you expect to happen?
Comment 6 James Forrester 2014-06-09 15:41:08 UTC
Closing temporarily as there's no proposed action. Please feel free to re-open.
Comment 7 Jared Zimmerman (WMF) 2014-06-09 17:30:45 UTC
Two possible proposals that we could use one, both, or some variations

When consecutive breaks are found we could use

<br>
<br>

which is what you'll commonly see on wikipages when people are trying to do some advanced formatting

if the <br> is followed by a [[template]] or == Section == we could strip out any <br> and replace with {{Clear}}
Comment 8 James Forrester 2014-06-26 00:28:41 UTC
(In reply to Jared Zimmerman (WMF) from comment #7)
> Two possible proposals that we could use one, both, or some variations
> 
> When consecutive breaks are found we could use
> 
> <br>
> <br>
> 
> which is what you'll commonly see on wikipages when people are trying to do
> some advanced formatting

… and is horrendous and explicitly deprecated.

> if the <br> is followed by a [[template]] or == Section == we could strip
> out any <br> and replace with {{Clear}}

This is verging on a WONTFIX, but leaving as a possible thing for later consideration.
Comment 9 Jared Zimmerman (WMF) 2014-06-26 00:33:46 UTC
Where do we draw the line about being paternalistic and disallowing users to do things they want to do but we don't think are "good code" or "stylistically wrong" it seems like in many cases we go to great lengths to make things possible or easy even if we think the outcome may be that users misuse or use in unexpected ways and other times we block on them by saying we don't want to be enablers of bad behavior. Curious in this case how that logic is applied to do, or not do this?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links