Last modified: 2014-11-07 01:45:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67760, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65760 - site.editpage may have Parameter 'md5'
site.editpage may have Parameter 'md5'
Status: UNCONFIRMED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All All
: Low enhancement
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-26 06:27 UTC by xqt
Modified: 2014-11-07 01:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description xqt 2014-05-26 06:27:34 UTC
This is the FIXME I removed from code at line 2690 in site.py:

        elif watch:
            pywikibot.warning(
                u"editpage: Invalid watch value '%(watch)s' ignored."
                % locals())
# FIXME: API gives 'badmd5' error
#        md5hash = md5()
#        md5hash.update(urllib.quote_plus(text.encode(self.encoding())))
#        params['md5'] = md5hash.digest()
        req = api.Request(site=self, **params)
        while True:

FIXME Introduced by:
Revision: 5c9752a1916ef062dde7f7f0b1f6cff51f482aa8
Author: Russell Blau <russblau@users.mediawiki.org>
Date: 16.12.2008 20:40:20
Message:
update properties

https://mediawiki.org/wiki/Special:Code/pywikipedia/6156

I am unsure whether is can be omitted
Comment 1 Amir Ladsgroup 2014-05-27 11:02:23 UTC
For the record:
https://gerrit.wikimedia.org/r/#/c/135307/2/pywikibot/site.py

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links